Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually write GCP KMS signer with full configuration #1789

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Conversation

adam-maj
Copy link
Contributor

@adam-maj adam-maj commented Oct 17, 2023

  • ethers-gcp-kms-signer package forces us to pass in application credentials in environment variables which doesn't work for engine
  • We fork the package here so the values can optionally be passed in the credentials (and environment variables still works as well)

@adam-maj adam-maj requested a review from a team October 17, 2023 20:36
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: 69bcc53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adam-maj
Copy link
Contributor Author

/release-pr

@adam-maj adam-maj enabled auto-merge October 17, 2023 20:58
@adam-maj adam-maj added this pull request to the merge queue Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Merged via the queue into main with commit 6413864 Oct 18, 2023
8 checks passed
@adam-maj adam-maj deleted the am/gcp-kms branch October 18, 2023 18:42
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
update deterministic deploy option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant