Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #906

Merged
merged 50 commits into from
Aug 12, 2024
Merged

Develop #906

merged 50 commits into from
Aug 12, 2024

Conversation

thkruz
Copy link
Owner

@thkruz thkruz commented Aug 11, 2024

No description provided.

thkruz added 30 commits August 9, 2024 12:23
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 21.07232% with 633 lines in your changes missing coverage. Please review.

Project coverage is 42.12%. Comparing base (43600d4) to head (4cd3866).
Report is 55 commits behind head on main.

Files Patch % Lines
src/singletons/draw-manager/sensor-fov-mesh.ts 0.00% 157 Missing ⚠️
src/singletons/draw-manager/cone-mesh.ts 0.00% 72 Missing ⚠️
src/plugins/satellite-fov/satellite-fov.ts 29.70% 69 Missing and 2 partials ⚠️
src/singletons/input-manager/keyboard-input.ts 10.52% 47 Missing and 4 partials ⚠️
...singletons/draw-manager/sensor-fov-mesh-factory.ts 9.30% 39 Missing ⚠️
src/plugins/sensor/sensorManager.ts 21.21% 26 Missing ⚠️
src/plugins/polar-plot/polar-plot.ts 12.00% 22 Missing ⚠️
src/singletons/draw-manager/custom-mesh.ts 0.00% 21 Missing ⚠️
src/singletons/camera.ts 55.55% 18 Missing and 2 partials ⚠️
src/singletons/draw-manager/cone-mesh-factory.ts 9.52% 19 Missing ⚠️
... and 21 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   45.22%   42.12%   -3.10%     
==========================================
  Files         157      167      +10     
  Lines       15356    17397    +2041     
  Branches     2891     2995     +104     
==========================================
+ Hits         6945     7329     +384     
- Misses       7400     9123    +1723     
+ Partials     1011      945      -66     
Files Coverage Δ
src/catalogs/sensors.ts 100.00% <ø> (ø)
src/keepTrackApi.ts 79.31% <100.00%> (ø)
src/plugins/satellite-view/satellite-view.ts 80.95% <100.00%> (-19.05%) ⬇️
src/plugins/sensor-fov/sensor-fov.ts 78.78% <100.00%> (+3.78%) ⬆️
src/plugins/sensor-surv/sensor-surv-fence.ts 87.50% <100.00%> (+7.50%) ⬆️
...rc/plugins/sensor/multi-site-look-angles-plugin.ts 66.45% <100.00%> (-1.39%) ⬇️
src/plugins/settings-menu/settings-menu.ts 54.05% <ø> (-0.79%) ⬇️
src/plugins/watchlist/watchlist-overlay.ts 17.07% <100.00%> (-0.03%) ⬇️
src/settings/settings.ts 56.38% <100.00%> (-0.97%) ⬇️
src/settings/versionDate.js 100.00% <100.00%> (ø)
... and 34 more

... and 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb60e1...4cd3866. Read the comment docs.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@thkruz thkruz merged commit 9cc8b20 into main Aug 12, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant