[DataGrid] perf: remove querySelector call (mui#12229)

thomasmoon · Sep 6, 2024 · 3e1040d · 3e1040d
1 parent 3de5d64
commit 3e1040d
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/x-data-grid/src/components/columnSelection/GridCellCheckboxRenderer.tsx b/packages/x-data-grid/src/components/columnSelection/GridCellCheckboxRenderer.tsx
@@ -52,18 +52,20 @@ const GridCellCheckboxForwardRef = React.forwardRef<HTMLInputElement, GridRender
 
     const rippleRef = React.useRef<TouchRippleActions>(null);
     const handleRef = useForkRef(checkboxElement, ref);
-    const element = apiRef.current.getCellElement(id, field);
 
     const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => {
       const params: GridRowSelectionCheckboxParams = { value: event.target.checked, id };
       apiRef.current.publishEvent('rowSelectionCheckboxChange', params, event);
     };
 
     React.useLayoutEffect(() => {
-      if (tabIndex === 0 && element) {
-        element!.tabIndex = -1;
+      if (tabIndex === 0) {
+        const element = apiRef.current.getCellElement(id, field);
+        if (element) {
+          element.tabIndex = -1;
+        }
       }
-    }, [element, tabIndex]);
+    }, [apiRef, tabIndex, id, field]);
 
     React.useEffect(() => {
       if (hasFocus) {