build: fix some tests, closes #2969

tests/bootstrap.php

@@ -39,6 +39,7 @@
 const DEBUG = true;
 
 $_SERVER['HTTP_HOST'] = 'https://localhost/';
+$_SERVER['SERVER_NAME'] = 'https://localhost/';
 
 require PMF_ROOT_DIR . '/content/core/config/constants.php';
 

tests/phpMyFAQ/Helper/FaqHelperTest.php

@@ -63,6 +63,9 @@ public function testCreateFaqUrl(): void
 
     public function testCleanUpContent(): void
     {
+        $this->expectException(SuspiciousOperationException::class);
+        $this->expectExceptionMessage('Invalid Host');
+
         $content = '<p>Some text <script>alert("Hello, world!");</script><img src=foo onerror=alert(document.cookie)></p>';
         $expectedOutput = '<p>Some text <img src="foo" /></p>';
 
@@ -74,6 +77,9 @@ public function testCleanUpContent(): void
 
     public function testCleanUpContentWithUmlauts(): void
     {
+        $this->expectException(SuspiciousOperationException::class);
+        $this->expectExceptionMessage('Invalid Host');
+
         $content = '<p>Hellö, wörld!</p>';
         $expectedOutput = '<p>Hellö, wörld!</p>';
 
@@ -84,6 +90,9 @@ public function testCleanUpContentWithUmlauts(): void
 
     public function testCleanUpContentWithYoutubeContent(): void
     {
+        $this->expectException(SuspiciousOperationException::class);
+        $this->expectExceptionMessage('Invalid Host');
+
         $content = <<<'HTML'
         <iframe 
           title="YouTube video player" 
@@ -106,6 +115,6 @@ public function testCleanUpContentWithYoutubeContent(): void
 
         $actualOutput = $this->faqHelper->cleanUpContent($content);
 
-        $this->assertStringStartsWith('<iframe', $actualOutput);
+        $this->assertEquals($expectedOutput, $actualOutput);
     }
 }

tests/phpMyFAQ/Instance/ClientTest.php

@@ -6,9 +6,9 @@
 use phpMyFAQ\Core\Exception;
 use phpMyFAQ\Database\Sqlite3;
 use phpMyFAQ\Filesystem;
-use phpMyFAQ\Instance;
 use phpMyFAQ\Strings;
 use PHPUnit\Framework\TestCase;
+use RecursiveIteratorIterator;
 
 /**
  * Class ClientTest
@@ -42,10 +42,10 @@ protected function tearDown(): void
     {
         @unlink(PMF_TEST_DIR . '/constants.test.php');
 
-        if (is_dir(PMF_TEST_DIR . '/assets/themes/default/')) {
-            $files = new \RecursiveIteratorIterator(
-                new \RecursiveDirectoryIterator(PMF_TEST_DIR . '/assets/themes/default/'),
-                \RecursiveIteratorIterator::SELF_FIRST
+        if (is_dir(PMF_TEST_DIR . '/assets/templates/default/')) {
+            $files = new RecursiveIteratorIterator(
+                new \RecursiveDirectoryIterator(PMF_TEST_DIR . '/assets/templates/default/'),
+                RecursiveIteratorIterator::SELF_FIRST
             );
             foreach ($files as $file) {
                 @unlink($file->getPathname());

tests/phpMyFAQ/Template/TwigWrapperTest.php

@@ -13,7 +13,7 @@ class TwigWrapperTest extends TestCase
      */
     protected function setUp(): void
     {
-        $this->twigWrapper = new TwigWrapper(PMF_TEST_DIR . '/assets/templates/default');
+        $this->twigWrapper = new TwigWrapper(PMF_ROOT_DIR . '/assets/templates/default');
     }
 
     /**