Add password input field that requires user authentication for unmasking #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
approved these changes
Oct 11, 2023
app-ui-catalog/src/main/java/app/k9mail/ui/catalog/CatalogActivity.kt
Outdated
Show resolved
Hide resolved
.../core/ui/compose/designsystem/biometric/atom/textfield/TextFieldOutlinedPasswordBiometric.kt
Outdated
Show resolved
Hide resolved
Variant of `PasswordInput` that only allows the password to be unmasked after the user has authenticated using `BiometricPrompt`.
cketti
force-pushed
the
textfield_reveal_authentication
branch
from
4414e1e to
6dbb94b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a compose variant of the password input field that only reveals its contents after the user has authenticated.
While this feature requires quite a bit of logic, it feels wrong to burden users of the password input component with implementing it. So I included the code in
TextFieldOutlinedPasswordBiometric(and to a minor degree inBiometricPasswordInput).I'm not sure about the name(s) of the components and the name of the Gradle module. Suggestions on how to name and structure this differently are welcome.