Replace StorageManager with StorageFilesProvider
#8677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
reviewed
Jan 10, 2025
|
|
||
| import java.io.File | ||
|
|
||
| interface DatabaseFilesProvider { |
There was a problem hiding this comment.
I think that StorageFilesProvider is more accurate as it provides the database file and attachment folder.
cketti
force-pushed
the
remove_StorageManager
branch
from
decf6b6 to
e268b6b
Compare
cketti
changed the title
StorageManager with DatabaseFilesProviderStorageManager with StorageFilesProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageManagerwas used to support storing the message database (and attachments) either on internal or external storage. We removed the ability to use anything but internal storage a while ago.This change moves the remaining functionality from
StorageManagertoStorageFilesProviderFactoryandStorageFilesProvider. This also allows us to removeK9MessageStore's dependency on the account UUID.