Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reduce logo size and ensure it resizes dynamically and fits all screen sizes #8710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SttApollo
Copy link

Fixes #8458

Description

This PR addresses #8458 where the logo on the onboarding screen flattened the text below. The WelcomeLogo composable has been updated to ensure dynamic resizing using BoxWithConstraints ensuring that the logo scales proportionally based on screen dimensions and fits properly without overlapping or pushing other components off-screen.

Changes Made

  • Updated WelcomeLogo to use BoxWithConstraints for adaptive sizing.
  • Limited logo and circle sizes to a maximum based on screen width.
  • Ensured LazyColumnWithHeaderFooter components are unaffected by the logo's size.
  • Verified compatibility across various screen sizes (small, medium, large, and tablets).

Testing

  • Tested on multiple screen sizes to ensure no scrolling is required and all components fit properly.

Visual Example

Screenshot 2024-12-29 at 3 33 02 PM
Screenshot 2024-12-29 at 3 28 56 PM
Screenshot 2024-12-29 at 3 29 19 PM

@wmontwe wmontwe self-assigned this Jan 6, 2025
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SttApollo This implementation reduces the logo size across all screen sizes, which diverges from the original design intention of making it prominent. To fix this, I suggest two changes:

  1. Slighlty reduce the logo size from its original values to have more room in general.
  2. Only use the shrinking logic when a certain maxWidth threshold is reached.

(Optional) Given the impracticality of fitting all page elements on every screen size, especially very small phones and in landscape mode, I think it would be more effective to use a scroll indicator in these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome / Get started screen has vertical content overflow
2 participants