Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Address of only one recipient not shown but "+1" #8718

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixes Address of only one recipient not shown but "+1" #8718

wants to merge 1 commit into from

Conversation

shamim-emon
Copy link
Contributor

@cketti cketti self-assigned this Jan 6, 2025
@cketti
Copy link
Member

cketti commented Jan 8, 2025

Can you explain why you believe this change will fix the problem? To me it looks like this will only help under very specific conditions like a particular text size combined with a particular screen size, but still fail in all other cases.

@shamim-emon
Copy link
Contributor Author

Can you explain why you believe this change will fix the problem? To me it looks like this will only help under very specific conditions like a particular text size combined with a particular screen size, but still fail in all other cases.

@cketti I viewed it as a starting point to explore potential solutions. Could you please provide suggestion on how I can approach this in a way so it convers broader range?

@cketti
Copy link
Member

cketti commented Jan 9, 2025

I viewed it as a starting point to explore potential solutions

In the future please include such information in the pull request description. Also include why you believe this is an approach that goes into the right direction.
In this specific case I currently don't see that this could be a promising approach.

Figuring out why the recipient chip is is replaced by "+1" and how to prevent that is probably the most important part of the task. We labeled the issue as something the community could work on because we don't have the time to investigate all issues ourselves.

@shamim-emon
Copy link
Contributor Author

I viewed it as a starting point to explore potential solutions

In the future please include such information in the pull request description. Also include why you believe this is an approach that goes into the right direction. In this specific case I currently don't see that this could be a promising approach.

Figuring out why the recipient chip is is replaced by "+1" and how to prevent that is probably the most important part of the task. We labeled the issue as something the community could work on because we don't have the time to investigate all issues ourselves.

@cketti got it. Thanks

@shamim-emon shamim-emon marked this pull request as draft January 9, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cketti cketti Awaiting requested review from cketti cketti is a code owner

@wmontwe wmontwe Awaiting requested review from wmontwe wmontwe is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@cketti cketti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address of only one recipient not shown but "+1"
2 participants
@shamim-emon @cketti