Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ACTION_CREATE_DOCUMENT returns a content: URI #8723

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Ensure ACTION_CREATE_DOCUMENT returns a content: URI #8723

merged 1 commit into from
Jan 9, 2025

Conversation

cketti
Copy link
Member

@cketti cketti commented Jan 8, 2025

This should fix https://github.com/thunderbird/thunderbird-android/security/code-scanning/8

Intent.ACTION_CREATE_DOCUMENT should always be handled by the system and never return anything but a content: URI. But it can't hurt to check.

@cketti cketti requested a review from wmontwe as a code owner January 8, 2025 13:46
wmontwe
wmontwe approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cketti cketti merged commit 04b95c6 into thunderbird:main Jan 9, 2025
3 checks passed
@cketti cketti deleted the check-for-content-scheme branch January 9, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cketti @wmontwe