Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constraining width of recipient token views #8734

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

cketti
Copy link
Member

@cketti cketti commented Jan 10, 2025

The old recipient token layout didn't properly constrain the width of the recipient token view.

I was able to fix the width issue using the existing ConstraintLayout. However, I wasn't able to get ConstraintLayout to reliably calculate the desired height of the layout and scale the image to the height of the container. In the end I gave up and added a custom layout.

Before After
image image

This is most likely a necessary change for fixing #7449.

@cketti cketti requested a review from wmontwe as a code owner January 10, 2025 18:00
@wmontwe wmontwe self-assigned this Jan 14, 2025
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cketti cketti merged commit 4cbaae3 into thunderbird:main Jan 17, 2025
3 checks passed
@cketti cketti deleted the recipient-token-view branch January 17, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants