Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address of only one recipient not shown but "+1" #8769

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

shamim-emon
Copy link
Contributor

@shamim-emon shamim-emon commented Jan 23, 2025

Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "Fixes #issue-number" will close the referenced issue once the pull request has been merged. However, this change only fixes one very specific case and not the entire problem. Please change the pull request description to use "see #7449" instead of "fixes".

The check for more than one token is performed after a bunch of work has been done that could have been avoided if there's only one token. Please move the check further up, to the "if (!hasFocus)" line.

Please also make sure to follow the code style. It's not automatically enforced for Java code. But there should be spaces around the comparison operator.

@shamim-emon
Copy link
Contributor Author

Using "Fixes #issue-number" will close the referenced issue once the pull request has been merged. However, this change only fixes one very specific case and not the entire problem. Please change the pull request description to use "see #7449" instead of "fixes".

The check for more than one token is performed after a bunch of work has been done that could have been avoided if there's only one token. Please move the check further up, to the "if (!hasFocus)" line.

Please also make sure to follow the code style. It's not automatically enforced for Java code. But there should be spaces around the comparison operator.

@cketti done

Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@cketti cketti merged commit 364d0cc into thunderbird:main Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants