Basic EAI support #8770
Basic EAI support #8770
Conversation
Thunderbird already supported the addresses substantively, since it uses the String type for addresses. That class has no support for ASCII-only strings, only for unicode strings. In effect, the programming language prevented Thunderbird from being incompatible with unicode addresses. RFC 6531 requires more than substantive compatibility though, it also requires correct declaration of the addresses, and that's what this commit adds.
An header such as From: info@xn--gr-zia.org is syntax according to RFCs 822 and 5322, but should not be shown to users because the "xn--gr-zia" is as user-unfriendly as it is phisher-friendly. This commit makes Thunderbird morph addresses that used xn-- into the pure unicode form on input. This change is not strictly related to EAI. However, it depends on SMTPUTF8 to keep the code simple: When a user replies to a message that used punycode, the reply's syntax often depends on RFC 6532, and sending the reply needs RFC 6531.
Once the server has sent ENABLED UTF8=ACCEPT, the server may send UTF8 in any string. This is not a problem for Thunderbird now, it didn't need changes to the parser. The purpose of these these two tests is to guard against any possible future breakage.
|
I'll have a coffee break now, then polish the mime4j tests so I can push that code. |
|
Hi Arnt, thanks for your pull request 👍 I think this should be split into multiple pull requests so we can focus on one aspect at a time. For example, adding support for My suggestion would be to start with a pull request just focusing on |
|
Hi, we can do that, but I don't see any point. This stuff is a little intermingled. Just one moment and I'll push all 6855 needs... |
|
Let's close this. I have all the code locally. I pushed the IMAP-specific code, I can push SMTP+necessary once the IMAP code is merged, and then then perhaps the rest after SMTP. |
This adds basic EAI support for Thunderbird/Android, bringing it to roughly the same level of support as other versions of Thunderbird: Can display messages to/from/cc
grå@grå.org, cannot usegrå@grå.orgas your own address.It requires a bit of code in MIME4J that I haven't pushed yet. With the currently released MIME4J and this PR, Thunderbird displays most of an EAI messages, but... it's complicated:
A later PR to tb will add a little more, but I wanted to get this out the door, because it's an improvement, and big enough that I was annoyed by the 8.2 version when I accidentally used it after getting used to this.
Waiting until all the functionality and dependencies are in place is of course an otion. That reminds me a little too much of RFC 1925 truth 5.
This doesn't break any unit tests, but two unit tests were failing already when I started this. I didn't investigate those.