Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACK-2864] Use direct registration signup links #141

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

darinkrauss
Copy link
Contributor

@darinkrauss darinkrauss commented Mar 19, 2024

Note: This PR is temporarily against BACK-2679/resolve-dependabot-issues.4 feature branch as I expect that to be deployed first. Will be rebased before final PR review.

- Use direct clinician or personal signup links
- Add basic SMTP notifier for local development (not used by default)
- https://tidepool.atlassian.net/browse/BACK-2864
@darinkrauss darinkrauss requested a review from toddkazakov March 19, 2024 01:02
@darinkrauss
Copy link
Contributor Author

/deploy qa5

@tidebot
Copy link
Collaborator

tidebot commented Mar 20, 2024

darinkrauss updated values.yaml file in qa5

@tidebot
Copy link
Collaborator

tidebot commented Mar 20, 2024

darinkrauss updated flux policies file in qa5

@tidebot
Copy link
Collaborator

tidebot commented Mar 20, 2024

darinkrauss deployed hydrophone BACK-2864-direct-registration-signup-links branch to qa5 namespace

@darinkrauss
Copy link
Contributor Author

/deploy dev1

@darinkrauss
Copy link
Contributor Author

/deploy dev

@tidebot
Copy link
Collaborator

tidebot commented Apr 1, 2024

darinkrauss updated values.yaml file in dev1

@tidebot
Copy link
Collaborator

tidebot commented Apr 1, 2024

darinkrauss updated flux policies file in dev1

@tidebot
Copy link
Collaborator

tidebot commented Apr 1, 2024

darinkrauss deployed hydrophone BACK-2864-direct-registration-signup-links branch to dev1 namespace

@darinkrauss
Copy link
Contributor Author

/deploy qa4

@tidebot
Copy link
Collaborator

tidebot commented Apr 1, 2024

darinkrauss updated values.yaml file in qa4

@tidebot
Copy link
Collaborator

tidebot commented Apr 1, 2024

darinkrauss updated flux policies file in qa4

@tidebot
Copy link
Collaborator

tidebot commented Apr 1, 2024

darinkrauss deployed hydrophone BACK-2864-direct-registration-signup-links branch to qa4 namespace

toddkazakov
toddkazakov previously approved these changes Apr 4, 2024
Base automatically changed from BACK-2679/resolve-dependabot-issues.4 to master April 12, 2024 01:37
@darinkrauss darinkrauss dismissed toddkazakov’s stale review April 12, 2024 01:37

The base branch was changed.

@darinkrauss darinkrauss requested a review from toddkazakov April 23, 2024 08:06
Copy link
Contributor

@toddkazakov toddkazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, in mailer I found logging to stdout good enough for development

@darinkrauss darinkrauss merged commit cec8c4c into master Apr 24, 2024
3 checks passed
@darinkrauss darinkrauss deleted the BACK-2864-direct-registration-signup-links branch April 24, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants