-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: npm packages #13886
chore: npm packages #13886
Conversation
Wow. This. PR. Is. Huge. Nice. |
my changes are only in the package.json :-) The rest is done with |
finally fixed the merge conflicts and linting errors. For comparison: before: not all but at least some 😄 |
updated stats: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through everything and made a bunch suggestions that you can click to accept.
I still need to audit all of the updated npom dependencies. I'm particularily interested in what changed in all major releases: arborist, archiver, fs-extra, chai, commander, conventional-changelog-cli, danger, eslint-config-axway, glob, husky, ssri, and strip-ansi. I don't know how each of these deps are used, so better to be safe than sorry.
iphone/TitaniumKit/TitaniumKit/Sources/Modules/TiUIWindowProxy.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Barber <chris@cb1inc.com>
nice 👍 Just a quick note: I think all the changes will automatically come back once someone runs |
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
@m1ga it seems like the linter gets confused in multi-line comments. If the linter still doesn't like the suggested indentations, then so be it. I'm curious what it'll say. |
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
That worked and it doesn't want to change them again when running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I audited the npm deps as best as I could. I did some testing and things look good. I'll approve and merge this PR, then we can get people to help test. APPROVED!
just some node package updates.
Updated my info list too #13781 as many are ESM packages now in newer versions.
Tested with kitchensink, hyperloop-example, my app and another client app (all Android only)
Had to run
npm run format:objc
to fix the lint errors