Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix TextArea hinttextid #13935

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix(android): fix TextArea hinttextid #13935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
898b404
fix(android): fix textarea hinttextid
m1ga Oct 14, 2023
5da2a09
fix(android): fix textarea hinttextid
m1ga Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions android/modules/ui/src/java/ti/modules/titanium/ui/TextAreaProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
TiC.PROPERTY_ENABLE_RETURN_KEY,
TiC.PROPERTY_FONT,
TiC.PROPERTY_FULLSCREEN,
TiC.PROPERTY_HINT_TEXT_ID,
TiC.PROPERTY_HINT_TEXT,
TiC.PROPERTY_HINT_TEXT_COLOR,
TiC.PROPERTY_HINT_TYPE,
Expand Down Expand Up @@ -61,6 +62,14 @@ public TextAreaProxy()
defaultValues.put(TiC.PROPERTY_HINT_TYPE, UIModule.HINT_TYPE_STATIC);
}

@Override
protected KrollDict getLangConversionTable()
{
KrollDict table = new KrollDict();
table.put(TiC.PROPERTY_HINT_TEXT, TiC.PROPERTY_HINT_TEXT_ID);
return table;
}

@Override
public void handleCreationArgs(KrollModule createdInModule, Object[] args)
{
Expand Down
8 changes: 8 additions & 0 deletions apidoc/Titanium/UI/TextArea.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,14 @@ properties:
default: No hint text.
platforms: [android]

- name: hinttextid
summary: |
Key identifying a string from the locale file to use for the
[hintText](Titanium.UI.TextArea.hintText) property.
description: Only one of `hintText` or `hinttextid` should be specified.
type: String
since: "6.2.0"

- name: hintTextColor
summary: Color of hint text that displays when field is empty.
platforms: [android]
Expand Down
Loading