fix(ios): fix duplicate application delegate allocation #14028
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the open scene-related bug that push registration did not fire the events properly, I noticed that during the scene integration, the main app router
TiApp
was instantiated twice, leading to an unpredicated behavior in the call tree.I fixed the issue by moving out all scene-related delegates into an own class that is only called by the initial scene configuration that calls the related
TiApp
code via it'sScenes
ObjC extension.I would like to prompt anyone reading this PR to test it properly, as it's (again) a pretty large change to polish the scene integration.
Open Todos:
TiApp
and it's categoryTiApp (Addons)
For the push-related testing, the following snippet will help: