Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: raise android max sdk support #14042

Merged
merged 2 commits into from
May 24, 2024
Merged

chore: raise android max sdk support #14042

merged 2 commits into from
May 24, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented May 21, 2024

Currently ti info will show a warning for Android 14 emulators:

  !  Android API Android 14 (android-34) is too new and may or may not work with Titanium SDK 12.3.0.
     The maximum supported Android API level by Titanium SDK 12.3.0 is API level 33.

  !  Android API Android VanillaIceCream (Preview) (android-VanillaIceCream) is too new and may or may 
     not work with Titanium SDK 12.3.0.
     The maximum supported Android API level by Titanium SDK 12.3.0 is API level 33.

Titanium works fine as we still have the compile/target SDK set to 33!

This PR will raise the max version in the SDK check so it will get rid of the warning.


Side note: #13940 is for updating the targetSDK once we have to (not required or announced by Google at the moment)

@m1ga m1ga requested a review from cb1kenobi May 23, 2024 10:36
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! APPROVED!

@cb1kenobi cb1kenobi merged commit eb87849 into master May 24, 2024
6 checks passed
@m1ga m1ga deleted the androidMaxVersion branch May 27, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants