Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win): permission issues when building a module #14078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jul 9, 2024

Fixes #14077

ti create -t module --id com.test -n test --android-code-base java -p android -d . && cd test/android && ti build -p android -b

will disable logging to file when you build a module on Windows.
BTW: on Linux I don't even have the build_android.log file but it won't show a permission error.

@cb1kenobi
Copy link
Contributor

As mentioned in the associated issue, I don't think this is the best solution.

@m1ga m1ga marked this pull request as draft July 10, 2024 08:36
@m1ga m1ga marked this pull request as ready for review January 15, 2025 12:30
@hansemannn
Copy link
Collaborator

hansemannn commented Jan 26, 2025

@m1ga I've noticed that you've marked this PR as ready-for-review. Looking at @cb1kenobi's comment, there may be additional work needed? I have seen the related issue that you've linked, but Chris should decide before merging.

@m1ga
Copy link
Contributor Author

m1ga commented Jan 26, 2025

correct, I've explained it in the last comment: #14077 (comment)
This fix will just be an intermediate fix to make module building on windows work again. It's only for Windows users that are trying to build modules. We had one report on Slack so far, so I don't think it is a common platform and people are missing the build log file because it wasn't there with CLI v6 either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: building modules will fail with permission error
3 participants