-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): collapse toolbar menu support #14093
Open
Max87ZA
wants to merge
67
commits into
tidev:master
Choose a base branch
from
Max87ZA:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge tidev master into max87 kotlin_1810
Kotlin 1810
fix(ios): removed bounce from TiAnimation feat(android): Added collapse_toolbar props
@Max87ZA can you start from a clean master branch? You branch has other changes so it's not only the collapse toolbar menu |
…issues on iOS 16+ (tidev#13586)" This reverts commit 50814d7.
Co-authored-by: Chris Barber <chris@cb1inc.com>
* Revert "Revert "fix(android): textfield padding (tidev#13279)" (tidev#13512)" This reverts commit 918388a. * fix(android): fix input value * reset padding --------- Co-authored-by: m1ga <migamiga@web.de> Co-authored-by: Michael Gangolf <m1ga@users.noreply.github.com>
* feat(ios): add “interactiveDismissModeEnabled” API * chore: add docs
@Max87ZA Quick ping, thx! |
* feat(android): more log output * remove if * change for loop * Update android/runtime/v8/src/native/modules/APIModule.cpp Co-authored-by: Chris Barber <chris@cb1inc.com> --------- Co-authored-by: Chris Barber <chris@cb1inc.com>
* chore(android): forward --sdk in module build process * optimize code
…14117) * fix(android): fix ListView layout with header and footer only * remove log * Update android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/ListViewHolder.java Co-authored-by: Chris Barber <chris@cb1inc.com> * rename variable --------- Co-authored-by: Chris Barber <chris@cb1inc.com>
* fix(android): use Barrier to set constraints Using Barrier, potentially avoiding an issue of improper layout cycles (refer video in PR). * fix(android): list-item shifts to left on having accessoryType field
…ection items (tidev#14124) * fix(android): fire marker event for all visible items in range of first to last visible item * chore: remove package.json files
This reverts commit 7904769.
* feat: support multi-scene applications * fix: add keys to template Info.plist to restore backwards compatibility # Conflicts: # iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.h # iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
@Max87ZA you'll need to make different branches for your PRs 😄 don't work in master as that will add all your fixes into one big PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for toolbar's menu to Collapse toolbat
Usage:
Create your Collapse toolbar as usual and then add to your controller: