Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): collapse toolbar menu support #14093

Open
wants to merge 67 commits into
base: master
Choose a base branch
from

Conversation

Max87ZA
Copy link

@Max87ZA Max87ZA commented Aug 6, 2024

Adds support for toolbar's menu to Collapse toolbat
Usage:
Create your Collapse toolbar as usual and then add to your controller:

        $.collapsingToolbar.addMenuItem(0,` 'Item title',  false); 
        $.collapsingToolbar.setOnMenuItemClickListener(function(e) {
        Ti.API.info("e.menuItemId: "+e.menuItemId);
            switch (e.menuItemId) {
                case 0:
                   Ti.API.log("Menu 0 clicked");
                    break;
            }
        });

@m1ga
Copy link
Contributor

m1ga commented Aug 8, 2024

@Max87ZA can you start from a clean master branch? You branch has other changes so it's not only the collapse toolbar menu

hansemannn and others added 6 commits August 27, 2024 15:04
Co-authored-by: Chris Barber <chris@cb1inc.com>
* Revert "Revert "fix(android): textfield padding (tidev#13279)" (tidev#13512)"

This reverts commit 918388a.

* fix(android): fix input value

* reset padding

---------

Co-authored-by: m1ga <migamiga@web.de>
Co-authored-by: Michael Gangolf <m1ga@users.noreply.github.com>
* feat(ios): add “interactiveDismissModeEnabled” API

* chore: add docs
@hansemannn
Copy link
Collaborator

@Max87ZA Quick ping, thx!

m1ga and others added 17 commits September 16, 2024 11:07
* feat(android): more log output

* remove if

* change for loop

* Update android/runtime/v8/src/native/modules/APIModule.cpp

Co-authored-by: Chris Barber <chris@cb1inc.com>

---------

Co-authored-by: Chris Barber <chris@cb1inc.com>
* chore(android): forward --sdk in module build process

* optimize code
…14117)

* fix(android): fix ListView layout with header and footer only

* remove log

* Update android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/ListViewHolder.java

Co-authored-by: Chris Barber <chris@cb1inc.com>

* rename variable

---------

Co-authored-by: Chris Barber <chris@cb1inc.com>
* fix(android): use Barrier to set constraints

Using Barrier, potentially avoiding an issue of improper layout cycles (refer video in PR).

* fix(android): list-item shifts to left on having accessoryType field
…ection items (tidev#14124)

* fix(android): fire marker event for all visible items in range of first to last visible item

* chore: remove package.json files
* feat: support multi-scene applications

* fix: add keys to template Info.plist to restore backwards compatibility
# Conflicts:
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.h
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
@m1ga
Copy link
Contributor

m1ga commented Jan 4, 2025

@Max87ZA you'll need to make different branches for your PRs 😄 don't work in master as that will add all your fixes into one big PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants