iOS 18 dark mode icons #14138
Merged
iOS 18 dark mode icons #14138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update _build.js for dark mode icon support and so dark mode and tinted icon is not flatted against a white background.
hansemannn
requested changes
Nov 9, 2024
|
@dlewis23 Did you have the chance to revisit the requested changes? |
|
@dlewis23 One quick ping here - we'd love to include it in the 12.6.0 RC later today, if you can adjust the changes and verify the fallback behavior (no dark mode icons set). Thank you! |
|
Sorry for the late reply @hansemannn I just tested, if you do not included the dark or tinted icon file with the app it will use the DefaultIcon-Marketing.png icon that is created and the system will make the dark and tinted icons. It does not seem like any code changes need to be made for 12.6.0 RC. |
|
Then you only need to fix the strict-equal checks marked up above :) |
Co-authored-by: Hans Knöchel <hansemannn@users.noreply.github.com>
Co-authored-by: Hans Knöchel <hansemannn@users.noreply.github.com>
hansemannn
approved these changes
Nov 29, 2024
|
Thanks @dlewis23 and @AbdullahFaqeir ! |
|
@hansemannn All Done. |
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #14122 add support for dark mode icons. Updated _build.js with changes made by @AbdullahFaqeir