Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make android mocha tests run again #14158

Merged
merged 11 commits into from
Jan 28, 2025
Merged

fix: make android mocha tests run again #14158

merged 11 commits into from
Jan 28, 2025

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Dec 18, 2024

I was wondering why the Android mocha tests weren't running anymore. Turns out: the generated tiapp.xml was invalid. There was a missing > and it had two <application> (we have a default one in the template now) nodes.

Fixing some tests:

Interesting point:
tableView.deleteRow(tableView.sections[0].rows[2]); is not working in the emulator but on a device it is working fine 🤷 That's one test that is still failing but couldn't fix it yet.

@m1ga
Copy link
Contributor Author

m1ga commented Jan 12, 2025

@prashantsaini1 maybe you can check this one too. Then the testsuite will run again (npm run tests). One small null check in the SDK, the rest is just JS fixes.

Just a note: there are still around 10 tests that fail in the emulator, but the outher thousand of tests run fine 😄

@prashantsaini1
Copy link
Contributor

This one's fine as I already noticed at other places that getNativeView is being used without null checks, whereas it should be guarded.

@hansemannn
Copy link
Collaborator

@prashantsaini1 Please review

@hansemannn hansemannn merged commit 1dd6438 into master Jan 28, 2025
6 checks passed
@m1ga m1ga deleted the fixAndroidTestXML branch January 28, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants