fix: binary data string key

.changeset/plenty-rocks-smell.md

@@ -0,0 +1,5 @@
+---
+"@reactive-dot/core": patch
+---
+
+Fixed string key generation of binary data.

packages/core/package.json

@@ -31,7 +31,8 @@
   "scripts": {
     "dev": "tsc --build --watch",
     "build": "rm -rf build && tsc --build",
-    "lint": "eslint src"
+    "lint": "eslint src",
+    "test": "vitest run"
   },
   "dependencies": {
     "@reactive-dot/utils": "workspace:^"
@@ -42,7 +43,8 @@
     "@tsconfig/strictest": "^2.0.5",
     "eslint": "^9.13.0",
     "polkadot-api": "^1.6.2",
-    "typescript": "^5.6.3"
+    "typescript": "^5.6.3",
+    "vitest": "^2.1.3"
   },
   "peerDependencies": {
     "polkadot-api": "1.x"

packages/core/src/utils/__snapshots__/stringify.test.ts.snap

@@ -0,0 +1,3 @@
+// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
+
+exports[`matches snapshot 1`] = `"{"array":[4,2,6,1],"bigInteger":"420","binary":"0x48656c6c6f2c20776f726c6421","boolean":true,"float":1.5,"integer":1,"null":null,"object":{"a":0,"b":1,"c":2},"string":"Hello, world!"}"`;

packages/core/src/utils/stringify.test.ts

@@ -0,0 +1,20 @@
+import { stringify } from "./stringify.js";
+import { Binary } from "polkadot-api";
+import { expect, it } from "vitest";
+
+it("matches snapshot", () => {
+  const string = stringify({
+    undefined: undefined,
+    null: null,
+    boolean: true,
+    integer: 1,
+    bigInteger: 420n,
+    float: 1.5,
+    string: "Hello, world!",
+    object: { b: 1, c: 2, a: 0 },
+    array: [4, 2, 6, 1],
+    binary: Binary.fromText("Hello, world!"),
+  });
+
+  expect(string).toMatchSnapshot();
+});

packages/core/src/utils/stringify.ts

@@ -1,5 +1,30 @@
-function hasObjectPrototype(o: unknown) {
-  return Object.prototype.toString.call(o) === "[object Object]";
+import { Binary } from "polkadot-api";
+
+export function stringify<T>(queryInstruction: T) {
+  return JSON.stringify(queryInstruction, (_, value) => {
+    if (typeof value === "bigint") {
+      return value.toString();
+    }
+
+    if (value instanceof Binary) {
+      return value.asHex();
+    }
+
+    if (isPlainObject(value)) {
+      return Object.keys(value)
+        .sort()
+        .reduce(
+          (result, key) => {
+            result[key] = value[key as keyof typeof value];
+            return result;
+          },
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
+          {} as any,
+        );
+    }
+
+    return value;
+  });
 }
 
 function isPlainObject(value: unknown): value is object {
@@ -24,25 +49,6 @@ function isPlainObject(value: unknown): value is object {
   return true;
 }
 
-export function stringify<T>(queryInstruction: T) {
-  return JSON.stringify(queryInstruction, (_, value) => {
-    if (typeof value === "bigint") {
-      return value.toString();
-    }
-
-    if (isPlainObject(value)) {
-      return Object.keys(value)
-        .sort()
-        .reduce(
-          (result, key) => {
-            result[key] = value[key as keyof typeof value];
-            return result;
-          },
-          // eslint-disable-next-line @typescript-eslint/no-explicit-any
-          {} as any,
-        );
-    }
-
-    return value;
-  });
+function hasObjectPrototype(o: unknown) {
+  return Object.prototype.toString.call(o) === "[object Object]";
 }

packages/core/tsconfig.json

@@ -12,5 +12,6 @@
     "sourceMap": true,
     "outDir": "build"
   },
-  "include": ["src"]
+  "include": ["src"],
+  "exclude": ["**/*.test.*"]
 }

packages/core/vitest.config.ts

@@ -0,0 +1,3 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({});

yarn.lock

@@ -4852,6 +4852,7 @@ __metadata:
     eslint: "npm:^9.13.0"
     polkadot-api: "npm:^1.6.2"
     typescript: "npm:^5.6.3"
+    vitest: "npm:^2.1.3"
   peerDependencies:
     polkadot-api: 1.x
   languageName: unknown