Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle command for Bible Icon Prefix setting, and add collapsible option for callout options #251

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AlphaHasher
Copy link
Contributor

The culprit:
Obsidian_llgiQRjuIc

The change made:
Obsidian_eQuqIFK6Rt

Notice the extra space that the extra <br/> tag makes when it is included?

@AlphaHasher AlphaHasher changed the title Remove the last <br/> tag that appears in LSB verses. Remove the last <br/> tag that appears in LSB verses and Add toggle command for Bible Icon Prefix setting Dec 28, 2024
@AlphaHasher
Copy link
Contributor Author

AlphaHasher commented Dec 28, 2024

Being able to switch between callouts and blockquote is a must have feature for me.
image

I'm also thinking about working on a toggle in the settings for if you want only the body text of the verse, no headers, or anything, just plain scripture. It would make it a lot easier to quote stuff on the fly.

@AlphaHasher AlphaHasher changed the title Remove the last <br/> tag that appears in LSB verses and Add toggle command for Bible Icon Prefix setting Remove last <br/> tag, add toggle command for Bible Icon Prefix setting, and add collapsible option for callout options Dec 28, 2024
@AlphaHasher
Copy link
Contributor Author

d1151c6 fixes #244

@tim-hub tim-hub self-requested a review January 14, 2025 09:18
@tim-hub
Copy link
Owner

tim-hub commented Jan 19, 2025

The culprit: Obsidian_llgiQRjuIc

The change made: Obsidian_eQuqIFK6Rt

Notice the extra space that the extra <br/> tag makes when it is included?

Hi @AlphaHasher

Thanks for your contribution, if you don't mind, can you explain the differences?

From the screenshot, I cannot see the differences between with or without <br/> .

@AlphaHasher
Copy link
Contributor Author

Absolutely, there is extra space under the verse when br is included.

399031607-f897850c-0e10-4c13-8521-44bd6ce8b8f4.png

None = 'None'
}

export const CollapsibleVersesCollection = [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure which is better.

Add None here or keep existing behaviour.

Does existing setting do the same things? Of Reference Position.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say keep it None. Also, the setting you point out does not affect the new option I added.

To make it clearer, I started testing (on my dev branch) disabling settings depending on other settings (e.g., if you don't want to use callouts, then the collapsible option can be disabled) but I ran into odd performance issues which I documented there.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a screenshot when the setting is CollapsibleVerses.None, at the same time, reference position is Header?

I am not sure what are the differences.

Thanks

@tim-hub
Copy link
Owner

tim-hub commented Jan 19, 2025

Absolutely, there is extra space under the verse when br is included.

399031607-f897850c-0e10-4c13-8521-44bd6ce8b8f4.png

Thanks I see now

Copy link
Owner

@tim-hub tim-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I make a humble suggestion?

  • To split the
    changes and collapsing changes to 2 different PRs.

  • changes are very clear and straight-forward.
  • The collapsing changes I am not very sure.

@AlphaHasher
Copy link
Contributor Author

Yes, I'll split them up

@AlphaHasher AlphaHasher changed the title Remove last <br/> tag, add toggle command for Bible Icon Prefix setting, and add collapsible option for callout options Add toggle command for Bible Icon Prefix setting, and add collapsible option for callout options Jan 19, 2025
@AlphaHasher
Copy link
Contributor Author

I have an idea. Since this pr relates to callouts, there can be a single settings whether the user wants to use callouts or not. If yes, it will shows more options, like whether or not they want it to be collapsible or not. Right now it is complicated and the end user would not know what settings do what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants