Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it compatible for pytorch latest version #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jizongFox
Copy link

Hi, just noticed this wonderful work. I have made this code available for latest PyTorch version by providing minor revisions. Please consider merging.

@izmailovpavel
Copy link
Collaborator

izmailovpavel commented Sep 29, 2019

Hi @jizongFox thanks for the PR. I will be able to take a close look in a week or so. I don't know if we want to add tqdm in adjust_learning_rate. If we do, why not in the train epoch as well?
Also, I guess we would want to somehow preserve compatibility with older PyTorch versions?
@timgaripov what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants