Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nrf52xxx/adc|spi): adjustable resolution, improve SPI #4660

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

feat(nrf52xxx/adc|spi): adjustable resolution, improve SPI #4660

wants to merge 9 commits into from
+164 −67

Conversation

milkpirate
Copy link

@milkpirate milkpirate commented Dec 15, 2024 •
edited
Loading

What I did

SPI

  • Create SPIMode type
  • Make SPI implement io.Reader, io.Writer
  • Update formatting to align with other switch-cases
  • Update SPI documentation reference

ADC

  • Change ADC methods to pointer receivers
  • Make ADC resolution adjustable
  • Remove nonsensical calculations (at least to me they seemed like, please correct me if I'm wrong)
  • Update ADC documentation reference

Open questions

  • Will make sense to change the signature of ADC.Get() to return an error? Since it will change the interface and might break things.
  • How to run the added tests?

@milkpirate
chore(src/machine/nrf52xxx): align formatting
00904a9 
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate
feat(src/machine/nrf52xxx/spi): add SPI mode type
f6f779b 
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate
refactor(src/machine/nrf52xxx/spi): set default in switch/case
2c8aead 
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate
feat(src/machine/nrf52xxx/spi): implement io.Reader, io.Writer
227f6dc 
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate
refactor(src/machine/nrf52xxx/spi): move buffer allocation to Transfe…
cec83a3 
…r method, use pointer receiver

Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate
chore(src/machine/nrf52xxx/adc): update documentation
223e299 
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate
fix(src/machine/nrf52xxx/adc): conversion
efd3f3d 
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate
refactor(src/machine/nrf52xxx/adc): make resolution configurable, poi…
7121e23 
…nter receiver, move init code

Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate milkpirate force-pushed the feat/nrf52xxx/adc/make-resolution-changeable branch 5 times, most recently from 72d63a4 to f10ed73 Compare December 16, 2024 22:25
@milkpirate milkpirate marked this pull request as ready for review December 16, 2024 22:36
@milkpirate
fix(src/machine/nrf52xxx): tests
c84ce10 
Signed-off-by: Paul Schroeder <milkpirate@users.noreply.github.com>
@milkpirate milkpirate force-pushed the feat/nrf52xxx/adc/make-resolution-changeable branch from f10ed73 to c84ce10 Compare December 17, 2024 00:16
ysoldak
ysoldak requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ysoldak ysoldak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this PR to be split into two: separately ADC and SPI changes.

You also need to justify the testify (:D) addition -- we don't have tests in machine package, probably better to make a separate PR for that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysoldak ysoldak ysoldak requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milkpirate @ysoldak