Fix acknow window #779
Draft
Fix acknow window #779
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisfeng
commented
Jan 6, 2025
Comment on lines
+79
to
95
| // Acknowledgements window for macOS 15+ | ||
| // Can't use else direct here since SceneBuilder does not implement it yet. | ||
| // Fix issue "Closure containing control flow statement cannot be used with result builder 'SceneBuilder'" | ||
| if #available(macOS 15.0, *) { | ||
| // Acknowledgements window | ||
| Window("setting.about.acknowledgements", id: .acknowledgementsWindowIdMacOS15Plus) { | ||
| AcknowListView() | ||
| } | ||
| .windowToolbarStyle(.unifiedCompact) | ||
| .defaultSize(width: 800, height: 600) | ||
| .restorationBehavior(.disabled) | ||
| } | ||
|
|
||
| // Acknowledgements window for macOS 15-, cannot use #unavailable | ||
| Window("setting.about.acknowledgements", id: .acknowledgementsWindowId) { | ||
| AcknowListView() | ||
| } |
There was a problem hiding this comment.
This code is not good. I tried to improve it, but didn't succeed. I know this is to pass the compilation. This is a problem with SwiftUI.
It seems we have no way to control a view to only display on macOS 15 or below, which will cause both Acknowledgements windows to be executed, including AcknowListView.
rm -rf ~/Library/Saved\ Application\ State/com.izual.Easydict.savedState
If this solution works, I suggest we do not add this code.
There was a problem hiding this comment.
Can we request the original issue creator to try the solution first. The window should not be saved in most cases. (That's explained why you and I both can't reproduce it.)
tisfeng
requested review from
AkaShark,
CanglongCl,
Kyle-Ye,
Jerry23011 and
phlpsong
Kyle-Ye
approved these changes
Jan 6, 2025
phlpsong
approved these changes
Jan 6, 2025
AkaShark
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#767 (comment)