Dean Fitzgerald - Blackjack #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,29 @@ | |||
| """Card class""" | |||
| """A card will collaborate with Shoe and Hand class""" | |||
| """A card is responsible for knowing its suit and rank""" | |||
There was a problem hiding this comment.
This should all be in the class docstring.
| player.bank += 10 | ||
| return False | ||
| elif dealer_hand_value < 17: | ||
| dealer_hand.add_card(Shoe.deal_card(Shoe())) |
There was a problem hiding this comment.
You're creating a new shoe every time here. Is that intentional? Also, even if that is, you should call Shoe().deal_card() instead. What you have works, but incidentally and isn't the correct usage.
|
@classicmurph -- this is definite improvement. I'd like to sit down and talk about it as well. Let's do that tomorrow or early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.