Quiz submission limit and Per Student Overrides #76

JasonGrace2282 · 2024-08-21T20:47:26Z

This PR

adds an optional limit to the amount of submissions on a assignment
allows for a different limit after the assignment is due
allows per student overrides for specific pieces of data on the Assignment model
adds tests to verify behavior

It adds two new views:

Manage Students: allows for a listing of students in the course and a button to manage their individual overrides. Accessible from Manage Students in the assignments show view.
Manage a specific student: form view for AssignmentOverride.

TODO

Implement the feature
Add tests
Add more tests (I don't trust myself)
Improve form CSS

tin/apps/assignments/models.py

tin/templates/assignments/show.html

First draft of allowing two submission caps for before and after a due date

tin/apps/assignments/views.py

krishnans2006

Nice feature! Here are some initial "gut reaction" questions/comments for you to consider:

tin/apps/assignments/admin.py

krishnans2006 · 2025-01-08T11:30:07Z

tin/apps/assignments/models.py

+    )
+    submission_cap_after_due = models.PositiveSmallIntegerField(
+        null=True,
+        validators=[MinValueValidator(1)],


Why can't the after-due-date-cap be zero? Seems like a logical use of the feature...

tin/apps/assignments/models.py

krishnans2006 · 2025-01-08T11:30:50Z

tin/apps/assignments/models.py

+    submission_cap_after_due = models.PositiveSmallIntegerField(
+        null=True,
+        validators=[MinValueValidator(1)],
+    )


Would be nice to have default values (e.g. 15 and 0) for both caps at the assignment level - this would also improve validation logic and make it consistent with validation for stuff like quiz action and grader timeout

krishnans2006 · 2025-01-08T11:31:10Z

tin/apps/assignments/models.py

+        on_delete=models.CASCADE,
+    )
+
+    submission_cap = models.PositiveSmallIntegerField()


Why can only one of the caps be overridden at the student level? Seems like it could be useful to change the post-due-date-cap on a per-student basis as well (to let someone submit late, for example)

Maybe it would be better to have a SubmissionCap model, and two foreignkeys to that model 🤔 that would solve most limitations.

krishnans2006 · 2025-01-08T11:32:18Z

tin/apps/assignments/urls.py

+        "<int:assignment_id>/manage_students/<int:student_id>",
+        views.manage_student,
+        name="create_student_override",
+    ),


I think assignments/X/students/ would be better than assignments/X/manage_students/

krishnans2006 · 2025-01-08T11:32:34Z

tin/apps/assignments/views.py

@@ -535,6 +585,8 @@ def submit_view(request, assignment_id):
        raise http.Http404

    student = request.user
+    if not assignment.within_submission_limit(student):
+        return http.HttpResponseForbidden("Submission limit exceeded")


The 403 for exceeding the limit seems harsh - maybe an error message would be nicer?

In theory, they shouldn't be able to even get to that screen without attempting to POST that URL or manualy entering the url.

Yeah, but I figured there's a possibility that someone has Tin open on two devices (e.g. phone, pc). So, they would submit until they reach the cap on pc, forget about it, then open the page and submit on phone.

Very obscure/rare scenario and it's probably too much effort to fix the way I described, but probably replacing it with a redirect to the assignment page would be a better solution.

krishnans2006 · 2025-01-08T11:33:11Z

tin/static/css/base.css

@@ -150,23 +150,26 @@ ul.no-list {
 ul#course-list,
 ul#assignment-list,
 ul#venv-list,
-ul#archive-list {
+ul#archive-list,
+ul.linebreak-list {


You should use #linebreak-list instead, I don't see why a class is necessary

krishnans2006 · 2025-01-08T11:35:09Z

tin/templates/assignments/manage_student.html

+{% extends "base.html" %}
+
+{% block main %}
+  <h2>Managing Student {{ user.username }}</h2>


Also, consider showing the default (assignment level) caps on this page, styled in a way that it helps teachers compare

krishnans2006 · 2025-01-08T11:36:05Z

tin/templates/assignments/show.html

@@ -36,6 +36,7 @@ <h2 class="left">{% if assignment.is_quiz %}[QUIZ] {% endif %}{{ assignment.name
        <a class="right tin-btn" href="{% url 'assignments:manage_grader' assignment.id %}" style="color:#EF1010;">Upload grader</a>
      {% endif %}
      <a class="right tin-btn" href="{% url 'assignments:manage_files' assignment.id %}">Manage files</a>
+      <a class="right tin-btn" href="{% url 'assignments:manage_students' assignment.id %}">Manage Students</a>


Suggested change

<a class="right tin-btn" href="{% url 'assignments:manage_students' assignment.id %}">Manage Students</a>

<a class="right tin-btn" href="{% url 'assignments:manage_students' assignment.id %}">Manage students</a>

…imit

JasonGrace2282 added the enhancement label Aug 21, 2024

JasonGrace2282 self-assigned this Aug 21, 2024

JasonGrace2282 requested a review from a team as a code owner August 21, 2024 20:47

JasonGrace2282 requested a review from krishnans2006 August 21, 2024 20:47

Add an optional submission cap and allow per-student overrides

bb81025

JasonGrace2282 force-pushed the quiz-sub-limit branch from d34fe99 to bb81025 Compare August 21, 2024 20:58

JasonGrace2282 added 2 commits August 21, 2024 17:00

revert a change

a4006f8

Use get_object_or_404

8fac970

JasonGrace2282 commented Aug 24, 2024

View reviewed changes

tin/apps/assignments/models.py Outdated Show resolved Hide resolved

tin/templates/assignments/show.html Outdated Show resolved Hide resolved

JasonGrace2282 marked this pull request as draft September 1, 2024 23:28

JasonGrace2282 added 3 commits September 1, 2024 21:02

First draft of rewriting PR

a5bd9d7

First draft of allowing two submission caps for before and after a due date

Add more tests and move tests into separate file

758f782

UI

0350e7b

JasonGrace2282 marked this pull request as ready for review September 4, 2024 02:16

JasonGrace2282 commented Sep 4, 2024

View reviewed changes

tin/apps/assignments/views.py Outdated Show resolved Hide resolved

JasonGrace2282 added 2 commits September 10, 2024 09:23

Add validation to AssignmentForm

00d781f

Remove math import

997f9d2

krishnans2006 requested changes Jan 8, 2025

View reviewed changes

JasonGrace2282 added 2 commits January 9, 2025 21:15

First attempt at reworking stuff completely

5541c5e

Merge branch 'master' of https://github.com/tjcsl/tin into quiz-sub-l…

88895da

…imit

krishnans2006 removed the enhancement label Jan 10, 2025

Simplify UI

6b79415

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quiz submission limit and Per Student Overrides #76

Quiz submission limit and Per Student Overrides #76

JasonGrace2282 commented Aug 21, 2024 •

edited

Loading

krishnans2006 left a comment

krishnans2006 Jan 8, 2025

krishnans2006 Jan 8, 2025

krishnans2006 Jan 8, 2025

JasonGrace2282 Jan 9, 2025

krishnans2006 Jan 8, 2025

krishnans2006 Jan 8, 2025

JasonGrace2282 Jan 9, 2025 •

edited

Loading

krishnans2006 Jan 10, 2025

krishnans2006 Jan 8, 2025

krishnans2006 Jan 8, 2025

krishnans2006 Jan 8, 2025

	<a class="right tin-btn" href="{% url 'assignments:manage_students' assignment.id %}">Manage Students</a>
	<a class="right tin-btn" href="{% url 'assignments:manage_students' assignment.id %}">Manage students</a>

Quiz submission limit and Per Student Overrides #76

Are you sure you want to change the base?

Quiz submission limit and Per Student Overrides #76

Conversation

JasonGrace2282 commented Aug 21, 2024 • edited Loading

TODO

krishnans2006 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JasonGrace2282 Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JasonGrace2282 commented Aug 21, 2024 •

edited

Loading

JasonGrace2282 Jan 9, 2025 •

edited

Loading