Improve instructions for dev env #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGrace2282
changed the title
selsayed25
previously approved these changes
Oct 7, 2024
JasonGrace2282
force-pushed
the
fix-dev
branch
from
dba8e01 to
8fa21a4
Compare
JasonGrace2282
force-pushed
the
fix-dev
branch
2 times, most recently
from
a17bda4 to
9b66af0
Compare
JasonGrace2282
force-pushed
the
fix-dev
branch
from
dc1dc32 to
10769db
Compare
This wrapper will only take effect if DEBUG is False and the sandboxing submodule isn't cloned.
JasonGrace2282
force-pushed
the
fix-dev
branch
from
10769db to
21e23d7
Compare
| @@ -273,5 +281,5 @@ def run_submission(submission_id): | |||
| submission.channel_group_name, {"type": "submission.updated"} | |||
| ) | |||
|
|
|||
| if os.path.exists(submission_wrapper_path): | |||
| with contextlib.suppress(FileNotFoundError): | |||
There was a problem hiding this comment.
Whats the reasoning behind this change?
There was a problem hiding this comment.
Generally, with file IO stuff, checking if a file exists before deleting it is considered an antipattern (just because some other process can delete the file in between checking if it exists and deleting it). Usually, it's better to try deleting the file and ignore any problems that occur (like if the file doesn't exist).
This is also why we have the exist_ok parameters with stuff like os.path.mkdirs/Path.mkdir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bunch of patches and stuff I had to do to get local submissions & venv's working working.
It also improves the documentation, and adds a script or two.