Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy model to prevent migration of view #529

Closed
jonespm opened this issue Jul 11, 2024 · 3 comments · Fixed by #530
Closed

Add proxy model to prevent migration of view #529

jonespm opened this issue Jul 11, 2024 · 3 comments · Fixed by #530
Assignees

Comments

@jonespm
Copy link
Member

jonespm commented Jul 11, 2024

Django is trying to migrate a view that was manually created, we should add a proxy model so it won't try to manage this. The alternative looks like might be a SAVEPOINT but this seems the best.

jonespm added a commit to jonespm/remote-office-hours-queue that referenced this issue Jul 11, 2024

Verified

This commit was signed with the committer’s verified signature.
TheBigLee Bigli
…naging the view
@jonespm jonespm moved this from To Do to In Progress in ROHQ 1.11.0 Jul 12, 2024
@jonespm jonespm self-assigned this Aug 12, 2024
jonespm added a commit that referenced this issue Oct 14, 2024
@github-project-automation github-project-automation bot moved this from In Progress to QA - Dev in ROHQ 1.11.0 Oct 14, 2024
@jonespm
Copy link
Member Author

jonespm commented Oct 31, 2024

To QA this just look at the logs and make sure there aren't any migrations waiting.

@zqian
Copy link
Member

zqian commented Oct 31, 2024

The QA log shows:

'Running migrations:
No migrations to apply.
Your models in app(s): 'officehours_api' have changes that are not yet reflected in a migration, and so won't be applied.
Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.'

@jonespm
Copy link
Member Author

jonespm commented Nov 1, 2024

Okay it looks like that error is related to this bug I just filed. #574

I thought it would be fixed by the Bluejeans removal but it requires more work. I don't think it's a blocker for this release and we'll just ignore the message until next release when this should all be cleaned up. We likely need to move this field out of the model and into the API and I wouldn't delay the release for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
2 participants