Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #529 - Adding a model to prevent Django from managing the view #530

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jonespm
Copy link
Member

@jonespm jonespm commented Jul 11, 2024

No description provided.

@jonespm jonespm linked an issue Jul 11, 2024 that may be closed by this pull request
@jonespm jonespm requested a review from jxiao21 July 11, 2024 20:56
@jonespm
Copy link
Member Author

jonespm commented Jul 11, 2024

@jxiao21 This should fix one of the migrations you're seeing. I think the other one is going to require removing bluejeans but I'll have to look more into it.

@jonespm jonespm requested review from lsloan and zqian and removed request for jxiao21 October 11, 2024 16:29
Copy link
Member

@zqian zqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a migration file for the newly added database table?

@jonespm
Copy link
Member Author

jonespm commented Oct 11, 2024

Hi @zqian. The idea of this was to prevent Django from trying to creating migration files for this.

There is already a migration to create this view, it was done manually in https://github.com/tl-its-umich-edu/remote-office-hours-queue/blob/master/src/officehours_api/migrations/0025_meeting_start_logs_view.py rather than through Django so this change will have Django ignore this and not try to drop the table.

@jonespm jonespm merged commit d7116e2 into tl-its-umich-edu:master Oct 14, 2024
@jonespm jonespm deleted the issue_529 branch October 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proxy model to prevent migration of view
2 participants