Tracing: Added Langsmith Support #1069
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeless
commented
Nov 21, 2024
| @@ -13,7 +13,6 @@ import ( | |||
| //nolint:all | |||
| type Handler interface { | |||
| HandleText(ctx context.Context, text string) | |||
| HandleLLMStart(ctx context.Context, prompts []string) | |||
There was a problem hiding this comment.
This call was dead code, it was not called anywhere
9 tasks
FluffyKebab
reviewed
Jan 6, 2025
langsmith/tracer.go
Outdated
|
|
||
| var _ callbacks.Handler = (*LangChainTracer)(nil) | ||
|
|
||
| type LangChainTracer struct { |
There was a problem hiding this comment.
Maybe LangChain is a little redundant here?
callbacks/context.go
Outdated
| // nolint: gochecknoglobals | ||
| var callbackHandlerKey = contextKeyType(0) | ||
|
|
||
| func CallbackHandler(ctx context.Context) Handler { |
There was a problem hiding this comment.
I think this function name is a somewhat redundant and vague. Maybe something like GetHandlerFromContext instead?
callbacks/context.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func WithCallback(ctx context.Context, handler Handler) context.Context { |
There was a problem hiding this comment.
I don't think a name like this works outside of the context package: callbacks.WithCallback
| @@ -42,21 +44,22 @@ func Call(ctx context.Context, c Chain, inputValues map[string]any, options ...C | |||
| fullValues[key] = value | |||
| } | |||
|
|
|||
| callbacksHandler := getChainCallbackHandler(c) | |||
There was a problem hiding this comment.
We should also check if there is a callback handler in the chain
|
I pushed the requested changes, add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces LangSmith tracing to the langchaingo library, enhancing debugging and monitoring capabilities for applications leveraging large language models (LLMs). These changes align with our observability needs and have been successfully running in production for several months.
We have subsequent PR ready to improve Inputs and Outputs capturing streamingfast#4
Key Features
LangSmith Tracing Integration:
callbacks.Handlerto enable tracing capabilities.Refactor and Enhancements:
chains.Call.chain.Callwas not passed to thellm.Modelinstance.Backward Compatibility
No breaking changes have been introduced. Tracing is optional and does not affect existing functionality when disabled.
Future Improvements
Refactor HandleLLMGenerateContentStart and HandleLLMGenerateContentEnd into a centralized GenerateContent function in the llms package to reduce code duplication across llms models.
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.