Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searching functionality to the chat selection screen #81

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

jrichardsen
Copy link
Collaborator

No description provided.

Signed-off-by: jrichardsen <jrichardsen@emlix.com>
@jrichardsen jrichardsen self-assigned this Jan 10, 2025
@jrichardsen jrichardsen requested a review from tofubert January 10, 2025 14:08
@jrichardsen
Copy link
Collaborator Author

Not sure whether the search bar should stay visible all the time. It is more discoverable that way, but in theory it wastes screen space...

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 43.33333% with 68 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ui/widget/chat_selector.rs 59.7% 35 Missing ⚠️
src/ui/app.rs 0.0% 33 Missing ⚠️
Files with missing lines Coverage Δ
src/ui/app.rs 0.0% <0.0%> (ø)
src/ui/widget/chat_selector.rs 85.7% <59.7%> (-9.0%) ⬇️

@tofubert
Copy link
Owner

I think visibility is good here, if there is to many rooms, we can always add a second column.

@jrichardsen jrichardsen merged commit 0484ee4 into main Jan 10, 2025
9 checks passed
@jrichardsen jrichardsen deleted the feature/chat-selector-search branch January 10, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants