Add More Error Logging When Indexing Fails #563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to debug an issue, I needed to add more logging to PGSync in order to see the problem. This PR adds additional logging similar to this one within the Elasticsearch community.
Before, I would see messages like:
While this did indicate something was wrong with the document, I did not know which one or why it was problematic. With this change, I now see errors containing:
This along with additional information such as the document shape (including
id
) have been valuable information.Note: This logging will only be visible with
ELASTICSEARCH_RAISE_ON_ERROR="false"
andELASTICSEARCH_RAISE_ON_EXCEPTION="false"
. This was thanks to the suggestion within #503 (comment)