-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Party like it's 2015 #92
Open
dschmidt
wants to merge
643
commits into
master
Choose a base branch
from
woah
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't report allowing artist type TomahawkUrl.
Add Urllookup to capabilities.
… Tomahawk. - Cleanup + safety
…op SDK is released
Add Netease resolver
…rl. Bump to version 0.2.1
Rhapsody resolver
…Bump to version 0.2.1.
… canParseUrl-function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR for changes in Tomahawk tomahawk-player/tomahawk#336
I had to change a few occurances of
Tomahawk.resolver.instance
in here, shouldn't be the case IMHO. We should really get rid of those (relying on a single instance here is a bad thing).Commits after Soundcloud work are not tested by any means, just wanted to get started and see how multiple files feel.
You need
tomahawkcc
to compile soundcloud, to a standalone resolver containing all necessary parts of formertomahawk.js
,rsvp.js
andalmond.js
(and AMD module loader).https://github.com/dschmidt/tomahawkcc
If you have a working
Node.js
environment, simplynpm install -g dschmidt/tomahawkcc
.If not, here's a standalone build, which should run on 64bit linux:
http://download.tomahawk-player.org/test/tomahawkcc