explictly set the SMB protocol when user doesnt specify

tombuildsstuff · Oct 27, 2021 · ce9f6d4 · ce9f6d4
1 parent a2a23ec
commit ce9f6d4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/storage/2020-08-04/file/shares/create.go b/storage/2020-08-04/file/shares/create.go
@@ -79,9 +79,11 @@ func (client Client) CreatePreparer(ctx context.Context, accountName, shareName
 		"x-ms-share-quota": input.QuotaInGB,
 	}
 
+	protocol := SMB
 	if input.EnabledProtocol != "" {
-		headers["x-ms-enabled-protocols"] = input.EnabledProtocol
+		protocol = input.EnabledProtocol
 	}
+	headers["x-ms-enabled-protocols"] = protocol
 
 	headers = metadata.SetIntoHeaders(headers, input.MetaData)
 

diff --git a/storage/2020-08-04/file/shares/lifecycle_test.go b/storage/2020-08-04/file/shares/lifecycle_test.go
@@ -74,6 +74,9 @@ func TestSharesLifecycle(t *testing.T) {
 	if share.ShareQuota != 1 {
 		t.Fatalf("Expected Quota to be 1 but got: %d", share.ShareQuota)
 	}
+	if share.EnabledProtocol != SMB {
+		t.Fatalf("Expected EnabledProtocol to SMB but got: %s", share.EnabledProtocol)
+	}
 
 	_, err = sharesClient.SetProperties(ctx, accountName, shareName, 5)
 	if err != nil {

diff --git a/storage/2020-08-04/file/shares/properties_get.go b/storage/2020-08-04/file/shares/properties_get.go
@@ -102,10 +102,11 @@ func (client Client) GetPropertiesResponder(resp *http.Response) (result GetProp
 			result.ShareQuota = quota
 		}
 
-		protocolRaw := resp.Header.Get("x-ms-enabled-protocols")
-		if protocolRaw != "" {
-			result.EnabledProtocol = ShareProtocol(protocolRaw)
+		protocol := SMB
+		if protocolRaw := resp.Header.Get("x-ms-enabled-protocols"); protocolRaw != "" {
+			protocol = ShareProtocol(protocolRaw)
 		}
+		result.EnabledProtocol = protocol
 	}
 
 	err = autorest.Respond(