-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix release_to_aur.yml #879
Conversation
Thanks for the fix, really appreciate it! For the windows CI failure, you can rebase your branch once #880 is merged:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
https://github.com/topgrade-rs/topgrade/actions/runs/11202404690/job/31138475242 Looks like there is still a problem. Is the SSH key up to date? |
Yeah, @s34m is the maintainer of the Topgrade package on AUR, I hope we can have him and give the SSH key a check: #844 (comment) |
I will check this out |
Thanks, appreciate it! 😄 |
I have regenerated the ssh key in the AUR and for the Github Action |
Thanks! |
Hi @s34m, could you please take another look at this? I just released v16.0.1 and we are still having the issue: https://github.com/topgrade-rs/topgrade/actions/runs/11285446857 |
@s34m you do not seem to be listed as a maintainer: https://aur.archlinux.org/packages/topgrade |
It would be ideal if both topgrade and topgrade-bin are updated by GH actions |
Mind telling me why? Do they have any difference? If not, I think one would be sufficient. 👀 |
Ah yes of course sorry. Some users rebuild package, and some prefer to use the binary from upstream. |
Makes sense to me, we should probably reach out to the maintainer of topgrade-bin for this. |
It seems like I am no longer maintainer of the topgrade package, probably due to the CD pipeline failing and the package being orphaned because of that. |
But the package has been updated pretty frequently, who did the update then 👀 |
@yochananmarqos might help us on that as he is listed as maintainer |
I think there might be a confusion. I've been the maintainer of the |
Hi @SinTan1729, thanks for being here! Also, thanks @androw for leaving that comment on AUR.
That would be great, could you please add @s34m as a con-maintainer so that we can release |
I'll be happy to. What is the AUR username? |
I guess it is also "s34m", as indicated by this comment, though I can not click the user name and check the profile(because I am not logged in?), so not 100% sure, let's wait for @s34m to answer the question. 🫣 |
@s34m your access has been restored. |
@SinTan1729 @yochananmarqos Thanks you two, and just to confirm it, my username is s34m. |
@s34m You've been added as a comaintainer. |
Thanks for all the help here! So our release_to_aur CI should work now, which will release the package topgrade, and @s34m's token can also be used to release topgrade-bin, do we need to set up another CI for this? |
Done in #944 |
What does this PR do
This PR change the action used to update AUR because the original one is not available on Github anymore.
Standards checklist
CONTRIBUTING.md
I haven't been able to test myself as it's linked to topgrade CI.