Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release_to_aur.yml #879

Merged
merged 1 commit into from
Jul 29, 2024
Merged

ci: fix release_to_aur.yml #879

merged 1 commit into from
Jul 29, 2024

Conversation

androw
Copy link
Contributor

@androw androw commented Jul 28, 2024

What does this PR do

This PR change the action used to update AUR because the original one is not available on Github anymore.

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

I haven't been able to test myself as it's linked to topgrade CI.

@SteveLauC
Copy link
Member

Thanks for the fix, really appreciate it!

For the windows CI failure, you can rebase your branch once #880 is merged:)

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@SteveLauC SteveLauC merged commit b1fe1d2 into topgrade-rs:main Jul 29, 2024
11 checks passed
@androw
Copy link
Contributor Author

androw commented Oct 6, 2024

https://github.com/topgrade-rs/topgrade/actions/runs/11202404690/job/31138475242

Looks like there is still a problem. Is the SSH key up to date?

@SteveLauC
Copy link
Member

Looks like there is still a problem. Is the SSH key up to date?

Yeah, @s34m is the maintainer of the Topgrade package on AUR, I hope we can have him and give the SSH key a check: #844 (comment)

@s34m
Copy link
Member

s34m commented Oct 7, 2024

I will check this out

@SteveLauC
Copy link
Member

I will check this out

Thanks, appreciate it! 😄

@s34m
Copy link
Member

s34m commented Oct 7, 2024

I have regenerated the ssh key in the AUR and for the Github Action

@SteveLauC
Copy link
Member

I have regenerated the ssh key in the AUR and for the Github Action

Thanks!

@SteveLauC
Copy link
Member

Hi @s34m, could you please take another look at this? I just released v16.0.1 and we are still having the issue: https://github.com/topgrade-rs/topgrade/actions/runs/11285446857

@androw
Copy link
Contributor Author

androw commented Oct 11, 2024

@s34m you do not seem to be listed as a maintainer: https://aur.archlinux.org/packages/topgrade

@SteveLauC
Copy link
Member

https://aur.archlinux.org/packages/topgrade

Actually, we have 3 Topgrade packages on AUR, as listed here. @s34m seems to be maintainer of this one, which is the most frequently updated one.

@androw
Copy link
Contributor Author

androw commented Oct 11, 2024

It would be ideal if both topgrade and topgrade-bin are updated by GH actions

@SteveLauC
Copy link
Member

Mind telling me why? Do they have any difference? If not, I think one would be sufficient. 👀

@androw
Copy link
Contributor Author

androw commented Oct 11, 2024

Ah yes of course sorry.
topgrade: the file provides instructions to build from source and install
topgrade-bin: the file provides instructions to download the binary from GitHub and install it

Some users rebuild package, and some prefer to use the binary from upstream.

@SteveLauC
Copy link
Member

Some users rebuild package, and some prefer to use the binary from upstream.

Makes sense to me, we should probably reach out to the maintainer of topgrade-bin for this.

@s34m
Copy link
Member

s34m commented Oct 11, 2024

It seems like I am no longer maintainer of the topgrade package, probably due to the CD pipeline failing and the package being orphaned because of that.
Which is a shitty situation.

@SteveLauC
Copy link
Member

But the package has been updated pretty frequently, who did the update then 👀

@androw
Copy link
Contributor Author

androw commented Oct 11, 2024

@yochananmarqos might help us on that as he is listed as maintainer

@SinTan1729
Copy link

SinTan1729 commented Oct 12, 2024

@s34m seems to be maintainer of this one

I think there might be a confusion. I've been the maintainer of the topgrade-bin package since 2022. I created the package because I just wanted a way to install topgrade without building it myself. As far as I know, the package didn't exist on AUR before I created it. Anyway, I'm willing to add comaintainters who are part of the project.

@SteveLauC
Copy link
Member

Hi @SinTan1729, thanks for being here! Also, thanks @androw for leaving that comment on AUR.

Anyway, I'm willing to add comaintainters who are part of the project.

That would be great, could you please add @s34m as a con-maintainer so that we can release topgrade-bin to AUR in our CI.

@SinTan1729
Copy link

SinTan1729 commented Oct 12, 2024

please add @s34m as a con-maintainer

I'll be happy to. What is the AUR username?

@SteveLauC
Copy link
Member

SteveLauC commented Oct 12, 2024

I guess it is also "s34m", as indicated by this comment, though I can not click the user name and check the profile(because I am not logged in?), so not 100% sure, let's wait for @s34m to answer the question. 🫣

Screenshot 2024-10-12 at 3 19 16 PM

@yochananmarqos
Copy link

@s34m your access has been restored.

@s34m
Copy link
Member

s34m commented Oct 12, 2024

@SinTan1729 @yochananmarqos Thanks you two, and just to confirm it, my username is s34m.

@SinTan1729
Copy link

SinTan1729 commented Oct 12, 2024

@s34m You've been added as a comaintainer.

@SteveLauC
Copy link
Member

Thanks for all the help here!

So our release_to_aur CI should work now, which will release the package topgrade, and @s34m's token can also be used to release topgrade-bin, do we need to set up another CI for this?

@androw androw mentioned this pull request Oct 13, 2024
3 tasks
@SteveLauC
Copy link
Member

do we need to set up another CI for this?

Done in #944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants