Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

build: upgrade dependencies #109

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

vuphuong245
Copy link
Contributor

@vuphuong245 vuphuong245 commented Dec 18, 2020

Description

  • found 2824 vulnerabilities (1777 low, 29 moderate, 1015 high, 3 critical) => no more
  • ../../nan/nan_converters_43_inl.h:22:1: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *' X(Boolean) => gone!

QA

  • Sanity test the plugin

@mcataford
Copy link
Contributor

Let's bring this up to date and get this shipped! 🚢

With a new and shiny CI, it should be a bit easier to move forward with changes.

Copy link
Contributor

@mcataford mcataford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, if we rebase and CI passes, I feel good about this. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants