Fix Pilulka.{cz,sk} widget #2079
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strajk
commented
Apr 3, 2024
Strajk
commented
Apr 3, 2024
rarous
requested changes
Apr 3, 2024
| const product = data.find(x => x["@type"] === "Product"); | ||
| // Give Nuxt 100ms to replace the json-ld script tag with correct data, | ||
| // otherwise it could contain old product when using SPA navigation | ||
| await new Promise(resolve => setTimeout(resolve, 100)); |
There was a problem hiding this comment.
Please, wait for the observed change of element. Don't introduce arbitrary race conditions.
There was a problem hiding this comment.
There has to be MutationObserver waiting for the change of the JSON+LD script. IIRC StatefulShop can be used for this, I think Mall.cz had something similar and might be used as inspiration at least for mechanics. Hard-coded time will break on slow devices...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pilulka took the SPA pill
Screenshot-2024-04-03T13.42.09.mp4