Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization / Performance cleanup #264

Merged
merged 6 commits into from
Feb 22, 2019
Merged

Optimization / Performance cleanup #264

merged 6 commits into from
Feb 22, 2019

Conversation

torch2424
Copy link
Owner

closes #230
closes #221
relates to #216
closes #207

This does some general optimizations across the app. And some general performance things mentioned that should be done. Also, this finally removes the legacy API from forever ago, and cleans that up.

In terms of performance, I've noticed this being between 1.02 - 1.04 times as fast than the current master. Which is nice, but it may just be a placebo type thing.

Screenshots

Everything working, and some benchmarks

screen shot 2019-02-21 at 1 53 51 am

screen shot 2019-02-21 at 2 05 33 am

screen shot 2019-02-21 at 2 05 45 am

@torch2424 torch2424 added enhancement New feature or request Core/Wasm Issues concerning the core library of Wasmboy Lib / JS Issues concerning the JS API of WasmBoy Benchmark Bugs concerning the Benchmarking WasmBoy App labels Feb 21, 2019
@torch2424 torch2424 self-assigned this Feb 21, 2019
@torch2424
Copy link
Owner Author

cc @MaxGraey 😄 Implemented your issues.

Though if you check the travis, seems like something on the latest master doesn't like the @inline decorator? 🤔

@MaxGraey
Copy link
Contributor

cc @dcodeIO

@inline export const enum CharCode {
 ~~~~~~~
 in ~lib/internal/string.ts(112,0)
ERROR: Parse error
    at parseBacklog (/home/travis/build/torch2424/wasmboy/node_modules/assemblyscript/cli/asc.js:363:23)
    at Object.main (/home/travis/build/torch2424/wasmboy/node_modules/assemblyscript/cli/asc.js:390:16)
    at Object.<anonymous> (/home/travis/build/torch2424/wasmboy/node_modules/assemblyscript/bin/asc:3:60)
    at Module._compile (internal/modules/cjs/loader.js:738:30)

@dcodeIO
Copy link
Contributor

dcodeIO commented Feb 21, 2019

I just recently made a change here that addressed a similar issue. Might that have borked it? Or is the AS version used here older? I believe that before that @inline didn't work for enums.

@MaxGraey
Copy link
Contributor

@torch2424 your local build works without this error? Try clean travis cache

@dcodeIO
Copy link
Contributor

dcodeIO commented Feb 21, 2019

Also keep in mind that dist files haven't been updated yet

@torch2424
Copy link
Owner Author

@MaxGraey My local build did work, but then I:

  • rm -rf node_modules && rm package-lock.json
  • npm install

And then I was getting the same error. However, I can try travis clean cache once I get home tonight.

@dcodeIO

Are the dist files used for the asc compiler? Perhaps I need to build from source, or wait until those are updated?

@torch2424
Copy link
Owner Author

@MaxGraey Actually, it seems like I don't have a travis cache. Thus, I can't clear it 😢

@torch2424
Copy link
Owner Author

Oh I guess it fixed itself, through another master update 😄

@torch2424 torch2424 merged commit 1de7031 into master Feb 22, 2019
@torch2424 torch2424 deleted the performance-cleanup branch February 22, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Bugs concerning the Benchmarking WasmBoy App Core/Wasm Issues concerning the core library of Wasmboy enhancement New feature or request Lib / JS Issues concerning the JS API of WasmBoy
Projects
None yet
3 participants