Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nonce race conditions and threshold check #128

Merged
merged 4 commits into from
Jan 24, 2024
Merged

fix nonce race conditions and threshold check #128

merged 4 commits into from
Jan 24, 2024

Conversation

himanshuchawla009
Copy link
Member

@himanshuchawla009 himanshuchawla009 commented Jan 23, 2024 •
edited
Loading

  • Updated test values as some of these accounts were upgraded to v2.
  • Replaced test account in devnet, as old test account was corrupted during testing for import keys.
  • Fixed nonce concurrency issue, return nonce corresponding to threshold key in case user has multiple keys.

chaitanyapotti
chaitanyapotti approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 2b45a12 into master Jan 24, 2024
1 check failed
@chaitanyapotti chaitanyapotti deleted the fix/nonce-race-conditions branch January 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshuchawla009 @chaitanyapotti