passkey connector apis #169
Open
+787
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieow
reviewed
Jan 13, 2025
| @@ -16,6 +12,13 @@ export interface TorusUtilsExtraParams { | |||
| rpOrigin?: string; // passkey, webauthn | |||
|
|
|||
| rpId?: string; // passkey, webauthn | |||
| } | |||
| export interface TorusUtilsExtraParams extends TorusUtilsPasskeyExtraParams { | |||
There was a problem hiding this comment.
Just question,
can we use just add TorusUtilsPasskeyExtraParams as a field in TorusUtilsExtraParams ?
Suggested change
| export interface TorusUtilsExtraParams extends TorusUtilsPasskeyExtraParams { | |
| export interface TorusUtilsExtraParams { | |
| passkeyParams: TorusUtilsPasskeyExtraParams |
There was a problem hiding this comment.
that's a good idea, we can do it in next breaking version. This change is not related to passkey linking. These are params for existing passkey/webauthn verifiers. I just divided it in seperate interface. We can do the change you are suggesting in next breaking version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: