Better User experience when getting data from API #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable "Show" button while we wait for api response. Prevents subsequent API requests until the first one has returned
Change "Show" button text to reflect Loading state during loading for better user experience
tananaev
reviewed
Dec 27, 2024
tananaev
reviewed
Dec 27, 2024
Define translation conditionally Co-authored-by: Anton Tananaev <anton.tananaev@gmail.com>
setLoading in a try>finally rather than referencing multiple times
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I noticed some of the code for this was already written, but was not yet incorporated into the Replay Page.
This prevents multiple API requests while the browser is waiting for a response from the server, and provides the user with some feedback about what's happening