Upgrade sjoe #120
Merged
Upgrade sjoe #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.5.5
Mathieu-Be
reviewed
Sep 20, 2023
contracts/StableJoeStaking.sol
Outdated
Comment on lines
65
to
67
| uint88 public depositFeePercent; | ||
| /// @notice Reentrancy guard | ||
| bool public reentrant; |
There was a problem hiding this comment.
This only work because depositFeePercent is zero atm. That's a bit dangerous imo, imagine we put this upgrade on hold for some reason, then later we update the deposit fee and decide to finally carry on the upgrade while forgetting about this
There was a problem hiding this comment.
Correct, but to me it's fine as it would just reset the value to 0. I'll use the right storage for safety, but I don't think it's necessary
Mathieu-Be
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to add a
sweepfunction to sJoe for non-reward token (and not joe).This PR also use immutable variables in order to save gas, to keep the storage ordering
__gapvariables are added.A non-reentrant check was added for improved security.