Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/aws-s3: remove console.error #5607

Merged
merged 1 commit into from
Jan 17, 2025
Merged

@uppy/aws-s3: remove console.error #5607

merged 1 commit into from
Jan 17, 2025

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Jan 16, 2025

Copy link
Contributor

Diff output files
diff --git a/packages/@uppy/aws-s3/lib/HTTPCommunicationQueue.js b/packages/@uppy/aws-s3/lib/HTTPCommunicationQueue.js
index d1bfe35..9c34fbd 100644
--- a/packages/@uppy/aws-s3/lib/HTTPCommunicationQueue.js
+++ b/packages/@uppy/aws-s3/lib/HTTPCommunicationQueue.js
@@ -431,9 +431,6 @@ async function _nonMultipartUpload2(file, chunk, signal) {
     signal,
   }).abortOn(signal);
   const key = fields == null ? void 0 : fields.key;
-  if (!key) {
-    console.error("Expected `fields.key` to be returend but the backend/Companion");
-  }
   _classPrivateFieldLooseBase(this, _setS3MultipartState)[_setS3MultipartState](file, {
     key: key,
   });

@Murderlon Murderlon changed the title Update HTTPCommunicationQueue.ts @uppy/aws-s3: remove console.error Jan 16, 2025
@mifi mifi merged commit efec237 into main Jan 17, 2025
16 checks passed
@mifi mifi deleted the mifi-patch-1 branch January 17, 2025 06:20
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
github-actions bot added a commit that referenced this pull request Jan 22, 2025
| Package         | Version | Package         | Version |
| --------------- | ------- | --------------- | ------- |
| @uppy/aws-s3    |   4.2.3 | @uppy/tus       |   4.2.2 |
| @uppy/companion |   5.5.1 | uppy            |  4.13.1 |

- @uppy/tus: fix resumeFromPreviousUpload race condition (Merlijn Vos / #5616)
- @uppy/aws-s3: Fixed default shouldUseMultipart (Mika Laitinen / #5613)
- meta: build(deps): bump docker/build-push-action from 6.11.0 to 6.12.0 (dependabot[bot] / #5611)
- @uppy/aws-s3: remove console.error (Mikael Finstad / #5607)
- @uppy/companion: unify http error responses (Mikael Finstad / #5595)
Murderlon added a commit that referenced this pull request Jan 23, 2025
* main: (38 commits)
  Release: uppy@4.13.1 (#5617)
  @uppy/tus: fix resumeFromPreviousUpload race condition (#5616)
  @uppy/aws-s3: Fixed default shouldUseMultipart (#5613)
  build(deps): bump docker/build-push-action from 6.11.0 to 6.12.0 (#5611)
  @uppy/aws-s3: remove console.error (#5607)
  @uppy/companion: unify http error responses (#5595)
  Release: uppy@4.13.0 (#5605)
  @uppy/aws-s3: always set S3 meta to UppyFile & include key (#5602)
  @uppy/companion: fix forcePathStyle boolean conversion (#5308)
  Fix Webpack CI (#5604)
  @uppy/aws-s3: allow uploads to fail/succeed independently (#5603)
  Revert "@uppy/aws-s3: allow uploads to fail/succeed independently"
  @uppy/aws-s3: allow uploads to fail/succeed independently
  Add types for css files (#5591)
  @uppy/unsplash: make utmSource optional (#5601)
  build(deps): bump docker/setup-qemu-action from 3.2.0 to 3.3.0 (#5599)
  build(deps): bump docker/build-push-action from 6.10.0 to 6.11.0 (#5600)
  @uppy/companion: add COMPANION_TUS_DEFERRED_UPLOAD_LENGTH (#5561)
  Release: uppy@4.12.2 (#5590)
  Import types consistently from @uppy/core (#5589)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants