Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT Documentation #674

Merged
merged 13 commits into from
Aug 25, 2016
Merged

JWT Documentation #674

merged 13 commits into from
Aug 25, 2016

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Jul 19, 2016

### .travis.yml

Add the encrypted key to the `jwt` section of the `.travis.yml`
file. For example:

This comment was marked as spam.

@BanzaiMan
Copy link
Contributor

I think it is a good idea to also update user/sauce-connect.md and alert to the use of JWT.

@halkeye
Copy link
Contributor Author

halkeye commented Jul 26, 2016

Rebased so google cloud link doens't break the build


Manually:

{% highlight yaml %}

This comment was marked as spam.

This comment was marked as spam.

@halkeye
Copy link
Contributor Author

halkeye commented Jul 29, 2016

@plaindocs I've updated things. Let me know what you think

I think I need to rebase to make the tests work again, but i'll do that after feedback is done.

@@ -60,11 +61,12 @@ For example, using the previous configuration `SAUCE_ACCESS_KEY` and

### How secure is this addon?

Very Secure. The token produced is only valid for 90 minutes, and is signed by but does not contain your secret information.
Very Secure. The token produced is only valid for 90 minutes. It is signed in such a way to uniquely securely
pass your secret information without worrying that information is leaked.

This comment was marked as spam.

@plaindocs
Copy link
Contributor

Cheers @halkeye ! I've left a couple more comments, and a pushed a commit to the main branch which fixes the build issue you were having.

@halkeye
Copy link
Contributor Author

halkeye commented Jul 30, 2016

@plaindocs those are all great, i'll get them merged asap

@halkeye
Copy link
Contributor Author

halkeye commented Jul 30, 2016

@plaindocs Replaced the text with your suggestions and rebased

All passed

I think we want to wait till travis-ci/travis-build#809 to do any merging


```javascript
{
"iss": "travis-ci.org",

This comment was marked as spam.

This comment was marked as spam.

@halkeye
Copy link
Contributor Author

halkeye commented Aug 2, 2016

@BanzaiMan @plaindocs I'm at a conference the rest of the week, so will be slow to update anything.

{
"iss": "Travis CI, GmbH",
"slug": "<SLUG>",
"pull-request": "<PR>",

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@halkeye
Copy link
Contributor Author

halkeye commented Aug 7, 2016

@BanzaiMan @plaindocs uptdated

Gavin Mogan and others added 4 commits August 9, 2016 14:50
use highlight macro to highlight source code, specifically yaml and json
Give examples using travis encrypt
@halkeye
Copy link
Contributor Author

halkeye commented Aug 9, 2016

Rebased~

@plaindocs
Copy link
Contributor

Great. So what is the status here? Do we need to merge this now?

@halkeye
Copy link
Contributor Author

halkeye commented Aug 14, 2016

I know we are itching to have this merged so we can start announcing it

On Aug 14, 2016 8:43 AM, "plaindocs" notifications@github.com wrote:

Great. So what is the status here? Do we need to merge this now?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#674 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGuB_JUaFKujmZEzIiqnqgXwezFn_-oks5qfzeLgaJpZM4JQSxS
.

@plaindocs
Copy link
Contributor

:-) :-) :-)

@BanzaiMan
Copy link
Contributor

We are working on a blog post as well.

@halkeye
Copy link
Contributor Author

halkeye commented Sep 1, 2016

@BanzaiMan Awesome.

I also made an attempt to fix travis lint - travis-ci/travis-yaml#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants