-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWT Documentation #674
JWT Documentation #674
Conversation
### .travis.yml | ||
|
||
Add the encrypted key to the `jwt` section of the `.travis.yml` | ||
file. For example: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I think it is a good idea to also update user/sauce-connect.md and alert to the use of JWT. |
Rebased so google cloud link doens't break the build |
|
||
Manually: | ||
|
||
{% highlight yaml %} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@plaindocs I've updated things. Let me know what you think I think I need to rebase to make the tests work again, but i'll do that after feedback is done. |
@@ -60,11 +61,12 @@ For example, using the previous configuration `SAUCE_ACCESS_KEY` and | |||
|
|||
### How secure is this addon? | |||
|
|||
Very Secure. The token produced is only valid for 90 minutes, and is signed by but does not contain your secret information. | |||
Very Secure. The token produced is only valid for 90 minutes. It is signed in such a way to uniquely securely | |||
pass your secret information without worrying that information is leaked. | |||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Cheers @halkeye ! I've left a couple more comments, and a pushed a commit to the main branch which fixes the build issue you were having. |
@plaindocs those are all great, i'll get them merged asap |
@plaindocs Replaced the text with your suggestions and rebased All passed I think we want to wait till travis-ci/travis-build#809 to do any merging |
|
||
```javascript | ||
{ | ||
"iss": "travis-ci.org", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@BanzaiMan @plaindocs I'm at a conference the rest of the week, so will be slow to update anything. |
{ | ||
"iss": "Travis CI, GmbH", | ||
"slug": "<SLUG>", | ||
"pull-request": "<PR>", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@BanzaiMan @plaindocs uptdated |
See: travis-ci/travis-build#356 travis-ci/travis-core#418 sebv/jwt-doc#5 For some historic context
use highlight macro to highlight source code, specifically yaml and json Give examples using travis encrypt
Rebased~ |
Great. So what is the status here? Do we need to merge this now? |
I know we are itching to have this merged so we can start announcing it On Aug 14, 2016 8:43 AM, "plaindocs" notifications@github.com wrote:
|
:-) :-) :-) |
We are working on a blog post as well. |
@BanzaiMan Awesome. I also made an attempt to fix travis lint - travis-ci/travis-yaml#97 |
See:
travis-ci/travis-build#356
travis-ci/travis-core#418
sebv/jwt-doc#5
For some historic context