added storage namespace validation on non-readonly bare repo creation

treeverse · Nov 24, 2024 · 74e509f · 74e509f
1 parent bd13a74
commit 74e509f
Showing 1 changed file with 15 additions and 31 deletions.
diff --git a/pkg/api/controller_test.go b/pkg/api/controller_test.go
@@ -198,39 +198,23 @@ func TestController_GetRepoHandler(t *testing.T) {
 		}
 	})
 
-	t.Run("use same storage namespace twice", func(t *testing.T) {
-		name := testUniqueRepoName()
-		resp, err := clt.CreateRepositoryWithResponse(ctx, &apigen.CreateRepositoryParams{}, apigen.CreateRepositoryJSONRequestBody{
-			Name:             name,
-			StorageNamespace: onBlock(deps, name),
-		})
-		verifyResponseOK(t, resp, err)
-
-		resp, err = clt.CreateRepositoryWithResponse(ctx, &apigen.CreateRepositoryParams{}, apigen.CreateRepositoryJSONRequestBody{
-			Name:             name + "_2",
-			StorageNamespace: onBlock(deps, name),
-		})
-		require.NoError(t, err)
-		require.Equal(t, http.StatusBadRequest, resp.StatusCode())
-	})
-}
-
-	t.Run("use same storage namespace twice with bare repo", func(t *testing.T) {
-		name := testUniqueRepoName()
-		resp, err := clt.CreateRepositoryWithResponse(ctx, &apigen.CreateRepositoryParams{}, apigen.CreateRepositoryJSONRequestBody{
-			Name:             name,
-			StorageNamespace: onBlock(deps, name),
-		})
-		verifyResponseOK(t, resp, err)
+	for _, isBareRepo := range []bool{false, true} {
+		t.Run(fmt.Sprintf("use same storage namespace twice, isBareRepo=%v", isBareRepo), func(t *testing.T) {
+			name := testUniqueRepoName()
+			resp, err := clt.CreateRepositoryWithResponse(ctx, &apigen.CreateRepositoryParams{}, apigen.CreateRepositoryJSONRequestBody{
+				Name:             name,
+				StorageNamespace: onBlock(deps, name),
+			})
+			verifyResponseOK(t, resp, err)
 
-    bareRepo := true
-		resp, err = clt.CreateRepositoryWithResponse(ctx, &apigen.CreateRepositoryParams{Bare: &bareRepo,}, apigen.CreateRepositoryJSONRequestBody{
-			Name:             name + "_2",
-			StorageNamespace: onBlock(deps, name),
+			resp, err = clt.CreateRepositoryWithResponse(ctx, &apigen.CreateRepositoryParams{Bare: &isBareRepo}, apigen.CreateRepositoryJSONRequestBody{
+				Name:             name + "_2",
+				StorageNamespace: onBlock(deps, name),
+			})
+			require.NoError(t, err)
+			require.Equal(t, http.StatusBadRequest, resp.StatusCode())
 		})
-		require.NoError(t, err)
-		require.Equal(t, http.StatusBadRequest, resp.StatusCode())
-	})
+	}
 }
 
 func testCommitEntries(t *testing.T, ctx context.Context, cat *catalog.Catalog, deps *dependencies, params commitEntriesParams) string {