Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for ListBranches "prefix" branch #8481

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

arielshaqed
Copy link
Contributor

Issue #8479 asks for this arg to lakectl. It exists on the API and is in use, but obviously we can do better at promoting it on the API - we can do that here.

@arielshaqed arielshaqed added area/API Improvements or additions to the API area/testing Improvements or additions to tests exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Jan 9, 2025
@arielshaqed arielshaqed added the pr/merge-if-approved Reviewer: please feel free to merge if no major comments label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

github-actions bot commented Jan 9, 2025

E2E Test Results - Quickstart

11 passed

Copy link
Contributor

@idanovo idanovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arielshaqed
Copy link
Contributor Author

Thanks for the speedy review! I'm puzzled why the Python wrapper test failed, it should not have been affected. So I'm rebasing on trunk, hoping that things will improve.

@arielshaqed
Copy link
Contributor Author

[...] I'm puzzled why the Python wrapper test failed, it should not have been affected. [...]

This turns out to have been a belated failure caused by #8482. Rebasing & merging.

Issue #8479 _asks_ for this arg, but it already exists.  It exists and is in
use, but obviously we can do better at promoting it.
@arielshaqed arielshaqed force-pushed the chore/8479-test-list-branches-prefix branch from 28e7c18 to 4369be5 Compare January 10, 2025 07:38
@arielshaqed arielshaqed enabled auto-merge (squash) January 10, 2025 07:38
@arielshaqed arielshaqed merged commit f2c6482 into master Jan 10, 2025
38 checks passed
@arielshaqed arielshaqed deleted the chore/8479-test-list-branches-prefix branch January 10, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API area/testing Improvements or additions to tests exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached pr/merge-if-approved Reviewer: please feel free to merge if no major comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants