Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upload-artifact action #8487

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Update upload-artifact action #8487

merged 2 commits into from
Jan 9, 2025
+21 −21

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Jan 9, 2025

Closes #8486

@N-o-Z N-o-Z self-assigned this Jan 9, 2025
@N-o-Z N-o-Z requested a review from arielshaqed January 9, 2025 17:30
@N-o-Z N-o-Z added the exclude-changelog PR description should not be included in next release changelog label Jan 9, 2025
arielshaqed
arielshaqed approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! The only reason not to approve would be if the API of upload-artifact changed in a way that breaks our CI. But... our CI is already broken, and if it passes now then clearly the API hasn't changed in such a way. So happy!

THANKS!

@arielshaqed
Copy link
Contributor

I think you may have missed this one?

@N-o-Z
Copy link
Member Author

N-o-Z commented Jan 9, 2025 •
edited
Loading

Approving! The only reason not to approve would be if the API of upload-artifact changed in a way that breaks our CI. But... our CI is already broken, and if it passes now then clearly the API hasn't changed in such a way. So happy!

(edited: wrong quote)
In that case I will make sure to request review again! Thanks!!!

@N-o-Z
Copy link
Member Author

N-o-Z commented Jan 9, 2025

Seems like it's good

@N-o-Z N-o-Z enabled auto-merge (squash) January 9, 2025 17:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

E2E Test Results - Quickstart

11 passed

@arielshaqed
Copy link
Contributor

LEBTM (looks even better to me), of course

@N-o-Z N-o-Z merged commit b2b1714 into master Jan 9, 2025
38 checks passed
@N-o-Z N-o-Z deleted the fix/upload-artifact-action-8486 branch January 9, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@N-o-Z N-o-Z

Labels
exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integration tests failing because of deprecated GH action
2 participants
@N-o-Z @arielshaqed