Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8422 list multipart uploads #8531

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Conversation

ItamarYuran
Copy link
Contributor

@ItamarYuran ItamarYuran commented Jan 21, 2025

Closes #8422

Introducing List Multiupart uploads command to the s3 gateway.

example command:
✗ aws s3api --endpoint-url=http://127.0.0.1:8000/ list-multipart-uploads --bucket itamar --profile default

This will return all multipart uploads (upload id and path) that are held by the tracker.

*missing functionality - an expired mpu is not deleted from tracker hanse presented while listing mpus

tests are still in process

@ItamarYuran ItamarYuran added the include-changelog PR description should be included in next release changelog label Jan 21, 2025
@ItamarYuran ItamarYuran linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 21, 2025

🎊 PR Preview 7b1500d has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-8531.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

github-actions bot commented Jan 21, 2025

E2E Test Results - Quickstart

10 passed, 1 failed

Test failures:
  Quickstart › pull requests: common/quickstart.spec.ts

quickstart.spec.ts:102:9 pull requests

[quickstart] › common/quickstart.spec.ts:102:9 › Quickstart › pull requests ──────────────────────

Test timeout of 30000ms exceeded.

Error: locator.click: Test timeout of 30000ms exceeded.
Call log:
  - waiting for locator('#pulls-tabs-tab-closed')


   at poms/pullsPage.ts:44

  42 |
  43 |     async gotoPullsTab(id: string): Promise<void> {
> 44 |         await this.page.locator(`#pulls-tabs-tab-${id}`).click();
     |                                                          ^
  45 |     }
  46 |
  47 |     async getFirstPullsRowDetails(): Promise<{title: string, description: string}> {

    at PullsPage.gotoPullsTab (/home/runner/work/lakeFS/lakeFS/webui/test/e2e/poms/pullsPage.ts:44:58)
    at /home/runner/work/lakeFS/lakeFS/webui/test/e2e/common/quickstart.spec.ts:142:25

attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
test-results/common-quickstart-Quickstart-pull-requests-quickstart/trace.zip
Usage:

    npx playwright show-trace test-results/common-quickstart-Quickstart-pull-requests-quickstart/trace.zip

────────────────────────────────────────────────────────────────────────────────────────────────

This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

@ItamarYuran ItamarYuran requested a review from a team January 22, 2025 10:04
@idanovo
Copy link
Contributor

idanovo commented Jan 22, 2025

@ItamarYuran Can you please make sure the CI passes first? 🙏

@ItamarYuran ItamarYuran force-pushed the 8422-listmultipartuploads branch from ce35f96 to 47a576e Compare January 23, 2025 06:39
@ItamarYuran ItamarYuran force-pushed the 8422-listmultipartuploads branch from 47a576e to cff37f2 Compare January 23, 2025 06:44
@ItamarYuran ItamarYuran force-pushed the 8422-listmultipartuploads branch from a40e68a to 62f9e44 Compare January 23, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LakeFS does not support the S3 ListMultipartUploads API
2 participants